Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add debounce de-amp rules #5373

Closed
cuba opened this issue May 24, 2022 · 1 comment · Fixed by #5536
Closed

Add debounce de-amp rules #5373

cuba opened this issue May 24, 2022 · 1 comment · Fixed by #5536
Assignees
@cuba
Labels
enhancement privacy QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes
Milestone
1.42

Comments

@cuba
Copy link
Contributor

cuba commented May 24, 2022

Description:

A small part of de-amping is debouncing. Modifications will be made to the debounce rules so it can handle some de-amping as well.

More rules can be found here: https://docs.google.com/document/d/1kvHbQMdE_vxmRWRz0LfAHzf6XoTT_pQXSwxth5rVhsk/edit#heading=h.gdplhac936j7

Additional Information
@cuba cuba self-assigned this May 24, 2022
cuba added a commit that referenced this issue Jun 16, 2022
@cuba
Fix #5373: Add regex debouncing
0b0c96a
cuba added a commit that referenced this issue Jun 16, 2022
@cuba
Fix #5373: Handle unsupported rules for debouncing
6b981b8
cuba added a commit that referenced this issue Jun 16, 2022
@cuba
Fix #5373: Add regex debouncing
96790ad
cuba added a commit that referenced this issue Jun 17, 2022
@cuba
Fix #5373: Add regex debouncing
089a8f2
cuba added a commit that referenced this issue Jun 17, 2022
@cuba
Fix #5373: Add regex debouncing
bf72c97
cuba added a commit that referenced this issue Jun 17, 2022
@cuba
Fix #5373: Add regex debouncing
1bae5d7
cuba added a commit that referenced this issue Jun 17, 2022
@cuba
Fix #5373: Add regex debouncing
435ad9c
cuba added a commit that referenced this issue Jun 21, 2022
@cuba
Fix #5373: Add regex debouncing
34d9139
cuba added a commit that referenced this issue Jun 21, 2022
@cuba
Fix #5373: Add regex debouncing
c28c669
cuba added a commit that referenced this issue Jun 22, 2022
@cuba
Fix #5373: Handle unsupported rules for debouncing
691ba6a
cuba added a commit that referenced this issue Jun 22, 2022
@cuba
Fix #5373: Add regex debouncing
a953427
cuba added a commit that referenced this issue Jun 22, 2022
@cuba
Fix #5373: Add regex debouncing
bad7c5f
cuba added a commit that referenced this issue Jun 22, 2022
@cuba
Fix #5373: Add regex debouncing
1e5423f
cuba added a commit that referenced this issue Jun 22, 2022
@cuba
Fix #5373: Add regex debouncing
47ef512
cuba added a commit that referenced this issue Jul 7, 2022
@cuba
Fix #5373: Add regex debouncing
870a18e
cuba added a commit that referenced this issue Jul 7, 2022
@cuba
Fix #5373: Add regex debouncing
aae4288
cuba added a commit that referenced this issue Jul 7, 2022
@cuba
Fix #5373: Handle unsupported rules for debouncing
5ec87e7
cuba added a commit that referenced this issue Jul 7, 2022
@cuba
Fix #5373: Add regex debouncing
bc219d6
cuba added a commit that referenced this issue Jul 8, 2022
@cuba
Fix #5373: Add regex debouncing
1e0ff20
cuba added a commit that referenced this issue Jul 8, 2022
@cuba
Fix #5373: Add regex debouncing
7daa62c
@fmarier fmarier mentioned this issue Jul 8, 2022
Merged
7 tasks
cuba added a commit that referenced this issue Jul 8, 2022
@cuba
Fix #5373: Add regex debouncing
5ff70f7
cuba added a commit that referenced this issue Jul 8, 2022
@cuba
Fix #5373: Add regex debouncing
af8ed6b
cuba added a commit that referenced this issue Jul 11, 2022
@cuba
Fix #5373: Add regex debouncing
9b1ad98
cuba added a commit that referenced this issue Jul 11, 2022
@cuba
Fix #5373: Add regex debouncing
b95f614
cuba added a commit that referenced this issue Jul 11, 2022
@cuba
Fix #5373: Add regex debouncing
3051317
cuba added a commit that referenced this issue Jul 11, 2022
@cuba
Fix #5373: Add regex debouncing
e6c7263
cuba added a commit that referenced this issue Jul 12, 2022
@cuba
Fix #5373: Handle unsupported rules for debouncing
9ad849b
cuba added a commit that referenced this issue Jul 12, 2022
@cuba
Fix #5373: Add regex debouncing
54bd010
iccub pushed a commit that referenced this issue Jul 20, 2022
@cuba @iccub
Fix #5373: Handle unsupported rules for debouncing
e087306
iccub pushed a commit that referenced this issue Jul 20, 2022
@cuba @iccub
Fix #5373: Add regex debouncing
9afe55e
cuba added a commit that referenced this issue Jul 21, 2022
@cuba
Fix #5373: Add regex debouncing
fdc7972
cuba added a commit that referenced this issue Jul 21, 2022
@cuba
Fix #5373: Handle unsupported rules for debouncing
e0b2f6b
cuba added a commit that referenced this issue Jul 21, 2022
@cuba
Fix #5373: Add regex debouncing
0989ed4
iccub pushed a commit that referenced this issue Jul 26, 2022
@cuba @iccub
Fix #5373: Handle unsupported rules for debouncing
32467eb
iccub pushed a commit that referenced this issue Jul 26, 2022
@cuba @iccub
Fix #5373: Add regex debouncing
2028401
@iccub iccub added this to the 1.42 milestone Jul 26, 2022
iccub pushed a commit that referenced this issue Jul 26, 2022
@cuba
Fix #5373: Add debounce de-amp rules (#5536)
1dd261c
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 17, 2022 •
edited
Loading

Verified using version 1.42 (22.8.15.22)

Test Devices:
iPhone 12/XR iOS 15.x
iPad iOS 15.5
iPhone X iOS 14.4.2

Verified using the test page in the test cases portion of brave/brave-browser#23121 (comment)

Tracking Disabled Tracking Enabled
IMG_0021 IMG_0022
IMG_0514 IMG_0515

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
enhancement privacy QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes
Projects
None yet
Milestone
1.42
Development

Successfully merging a pull request may close this issue.

Fix #5373: de amp debounce brave/brave-ios
3 participants
@cuba @iccub @Uni-verse