Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Include option for users to hide privacy stats and favorites from the NTP #6003

Closed
anthonypkeane opened this issue Sep 12, 2022 · 3 comments · Fixed by #6048
Closed

Include option for users to hide privacy stats and favorites from the NTP #6003

anthonypkeane opened this issue Sep 12, 2022 · 3 comments · Fixed by #6048

Comments

@anthonypkeane
Copy link

Description:

brave/brave-browser#22921

Details TBD, we may be able to follow android

@iccub
Copy link
Contributor

iccub commented Sep 14, 2022

@Sam-Sibley for settings placement, name and icon

@anthonypkeane
Copy link
Author

Possible Design

Screenshot 2022-09-19 at 3 08 09 pm

@soner-yuksel soner-yuksel self-assigned this Sep 20, 2022
@soner-yuksel soner-yuksel added this to the 1.44 milestone Sep 23, 2022
@iccub iccub changed the title Include option for users to hide privacy stats from the NTP Include option for users to hide privacy stats and favorites from the NTP Oct 7, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 11, 2022

Verified using 1.44 (22.10.10.19) using the following device(s):

iPhone 12 | iOS 16.x
iPhone XR | iOS 15.x
iPhone X | iOS 14.x
iPad (7th Gen) | iPadOS 15.x

Privacy Hub - PASS

Verified the following use case(s):

  • Privacy Hub is shown by default
  • Disabling Privacy Hub via NTP
  • Disabling Privacy Hub via settings switch
  • Loading NTP with only Privacy Hub enabled
  • Re-enabling Privacy Hub after it has been disabled
  • Disabling Privacy Hub in Private Browsing mode
  • With Favorites being enabled and privacy hub disabled on multiple tabs, re-enabling privacy hub and disabling favorites will update the tabs when user loads them.
Example Example Example
IMG_3878 IMG_3872 IMG_3879
Favorites - PASS

Verified the following use case(s):

  • Favorites are showing by default
  • Disabling Favorites with the settings switch under New Tab Page will remove Favorites from each open tab
  • Re-Enabling Favorites
  • Creating new favorites using the share menu will also respect the switch
Example Example
IMG_3876 IMG_3873
Settings Menu - PASS
  • Verified widget switch are situated in the New Tab Page settings menu
  • Verified user is able to toggle switches
  • Verified user is able to access background images sub menu
  • Verified disabling sponsored images will show normal/traditional backgrounds
Example Example
IMG_3879 IMG_3877
Testing on iPads
  • Menu
  • Favorites
  • Privacy Hub
  • BP Mode
  • Empty NTP
  • En-enabling
  • Disabling/Enabling Sponsored images
Example Example Example Example Example Example
IMG_0640 IMG_0641 IMG_0642 IMG_0643 IMG_0644 IMG_0645

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.