Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #1938: Implement P3A on iOS #6308

Merged
merged 13 commits into from
Nov 16, 2022
Merged

Fix #1938: Implement P3A on iOS #6308

merged 13 commits into from
Nov 16, 2022

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Nov 2, 2022

Summary of Changes

This pull request fixes #1938 Security Ticket: https://github.com/brave/security/issues/1088

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

N/A

Screenshots:

exppreservep1 3

Debug:

Logs2 7

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.45 milestone Nov 2, 2022
@soner-yuksel soner-yuksel requested review from kylehickinson and a team November 2, 2022 17:08
@soner-yuksel soner-yuksel marked this pull request as ready for review November 2, 2022 17:12
@soner-yuksel soner-yuksel modified the milestones: 1.45, 1.46 Nov 2, 2022
@soner-yuksel soner-yuksel deleted the p3a-ui branch November 16, 2022 15:18
@iccub iccub mentioned this pull request Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement P3A on iOS
4 participants