Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow Up] #1938: P3A alignment and UI fixes for onboarding #6470

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Nov 23, 2022

Summary of Changes

Fixing p3a popover tablet size width, switch toggle location, also fixes dismiss presentation after moving onboarding to different target so there will not be any view shown before dismiss

No ticket created cause the feature is not tested yet.

This pull request reference #1938

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Screenshots:

test1 2

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.46 milestone Nov 23, 2022
@soner-yuksel soner-yuksel requested a review from a team November 23, 2022 22:30
@soner-yuksel soner-yuksel self-assigned this Nov 23, 2022
@soner-yuksel soner-yuksel changed the title [No Bug]: P3A alignment and UI fixes for onboarding [Follow Up] #1938: P3A alignment and UI fixes for onboarding Nov 23, 2022
@soner-yuksel soner-yuksel merged commit 7661852 into development Nov 24, 2022
@soner-yuksel soner-yuksel deleted the fix/p3a-onboarding-popups branch November 24, 2022 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants