Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #1938: Settings P3A Localization #6497

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Nov 28, 2022

Summary of Changes

Changing Privacy Preserving Settings Localization Text

This pull request references #1938

Changes according:

https://github.com/brave/security/issues/1088#issuecomment-1314263655

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

N/A

Screenshots:

p3a1 1

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.46 milestone Nov 28, 2022
@soner-yuksel soner-yuksel requested a review from a team November 28, 2022 16:22
@soner-yuksel soner-yuksel self-assigned this Nov 28, 2022
@soner-yuksel soner-yuksel merged commit c7486f2 into development Nov 28, 2022
@soner-yuksel soner-yuksel deleted the fix/p3a-settings-localization branch November 28, 2022 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants