Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Adds Wallet creation loader and failure message to panel opt in #229

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 23, 2018

Fixes #228

Related to: brave/brave-browser#1502

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button for error shouldn't be disabled, but should be a try again button

level='secondary'
size='call-to-action'
type='subtle'
text={'Try Again'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add locale here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

walletFailedButton

type='subtle'
text={'Try Again'}
onClick={optInAction}
data-test-id='optInAction'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should be like optInErrorAction

@NejcZdovc NejcZdovc merged commit 787c53d into brave:master Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants