This repository has been archived by the owner on May 13, 2024. It is now read-only.
Adding grant claim process to wallet panel #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
force-pushed
the
panel-claim-grant
branch
from
1948f0f
to
15fce4f
Compare
ryanml
changed the title
ryanml
force-pushed
the
panel-claim-grant
branch
from
15fce4f
to
18f03b8
Compare
ryanml
force-pushed
the
panel-claim-grant
branch
from
18f03b8
to
a8c814f
Compare
cezaraugusto
approved these changes
Dec 12, 2018
18 tasks
ryanml
added a commit
that referenced
this pull request
Dec 19, 2018
Adding grant claim process to wallet panel
NejcZdovc
pushed a commit
that referenced
this pull request
Jan 14, 2019
Adding grant claim process to wallet panel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: brave/brave-browser#1783
Storybook: https://brave-ui-qsewcjabsx.now.sh
Low-res gif of the action ;) - https://media.giphy.com/media/xWCzAfIV0T5mtP7DJD/giphy.gif
Can be viewed under Feature Components > Rewards > Concepts > Desktop > Wallet Panel
Reviewers note: Please also check out the existing settings captcha implementation and ensure it is unaffected by these changes.
Additional Note: I purposefully did not add the down arrow and circle around the BAT logo in the design, as I have some concerns it may affect captcha results. I think this PR should be integrated in to core once reviewed, then once we are sure all is fine we can follow up and add it back.