Add test seed upload workflow. #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
force-pushed
the
upload-seed-in-pr
branch
18 times, most recently
from
8f885a5
to
6b81f9d
Compare
goodov
force-pushed
the
upload-seed-in-pr
branch
from
6b81f9d
to
4916c97
Compare
✅ Test Seed Generated SuccessfullyTo test the new seed, launch the browser with the following command line: Seed Details
|
goodov
force-pushed
the
upload-seed-in-pr
branch
8 times, most recently
from
99fe40e
to
78094f7
Compare
goodov
force-pushed
the
upload-seed-in-pr
branch
2 times, most recently
from
69bed89
to
86cf705
Compare
atuchin-m
reviewed
Jul 10, 2024
| const comment = require('.github/workflows/scripts/comment.js') | ||
| await comment(github, context, commentBody) | ||
|
|
||
| - name: Install dependencies and run tests |
There was a problem hiding this comment.
nit: could we split it into?
- npm install
- build proto & typecheck
- tests
atuchin-m
reviewed
Jul 10, 2024
| const comment = require('.github/workflows/scripts/comment.js') | ||
| await comment(github, context, commentBody) | ||
|
|
||
| - name: Comment "Upload Failed" |
There was a problem hiding this comment.
I would prefer to move this up and rename to "Upload skipped due to a build/lint/test failure".
Not sure that we should make a fallback for s3 uploading / invalidation, because it's a very small chance of failure here. IMHO, if it happens it's enough to have "Upload In Progress" comment and the failed job in the list.
atuchin-m
reviewed
Jul 10, 2024
| REMOTE_SEED_PATH: 'pull/${{ github.event.pull_request.number }}/seed' | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4 |
goodov
force-pushed
the
upload-seed-in-pr
branch
14 times, most recently
from
cebc893
to
e961aaf
Compare
atuchin-m
reviewed
Jul 10, 2024
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| if: github.event.pull_request.merged == true |
There was a problem hiding this comment.
what if the PR is declined?
There was a problem hiding this comment.
ah, we don't need this check at all.
goodov
force-pushed
the
upload-seed-in-pr
branch
from
e961aaf
to
8334f2e
Compare
atuchin-m
approved these changes
Jul 10, 2024
goodov
force-pushed
the
upload-seed-in-pr
branch
from
25e40aa
to
cfe4139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workflows for upload and removal of test seed.
Add a single study to test these workflows.