Support seed version setting #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Test Seed Generated SuccessfullyTo test the new seed, launch the browser with the following command line: Seed Details
|
goodov
force-pushed
the
set-version
branch
5 times, most recently
from
83a3f40
to
45a2fd9
Compare
24 tasks
atuchin-m
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seed proto has
serial_numberandversionfields.serial_numberis used as etag value for fetching purposes, this value is not public.versionon the other hand is a more public string that is also added to crash dumps. We should fill it with a sane value that can be used for debugging purposes.This change adds support for setting it to arbitrary string. The value will be displayed on
brave://versionafter brave/brave-core#24604 is merged.Example:
