-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update seed testing instruction. #1129
Conversation
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
11d4e26
to
14b9689
Compare
cc @brave/qa-team can you please proof-read the instruction about testing the seed and improve it if possible (see the comment in this pull request)? Maybe you have a better naming internally for "the debug menu" on android/ios respectively. |
seed/seed.json
Outdated
@@ -2948,7 +2948,7 @@ | |||
"Playlist" | |||
] | |||
}, | |||
"name": "Enabled", | |||
"name": "Enabledd", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this about? Is it an intentional change, or a typo?
The rest looks good to me for desktop 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a test change to trigger the seed generation (I'm not going to commit it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the issue that @stephendonner pointed out re: Enabledd
. Instructions should be good enough. At this point, most of QA should be able to figure out how to verify using the new method but I'll point them to our verifications via brave/brave-core#24604 (comment) which should have enough context/information.
The point here is so any developer who sees |
14b9689
to
2c553a1
Compare
2c553a1
to
7a1e77d
Compare
yup, makes sense 👍 |
No description provided.