Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the merge commit as seed version #1167

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Use the merge commit as seed version #1167

merged 1 commit into from
Aug 8, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Aug 8, 2024

Turns out, actions/checkout always uses a merge pin in workflows. This is good, because we will always get the test seed merged with the latest seed available in main, but to correctly differentiate such seed, we should use the merge commit as the seed version.

@goodov goodov force-pushed the display-merge-sha branch 4 times, most recently from dc02187 to d954f47 Compare August 8, 2024 16:25
Copy link
Contributor

github-actions bot commented Aug 8, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1167.
    Android: Set the command line to --variations-pr=1167 in debug menu, restart the browser.
    iOS: Set Variations PR to 1167 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1167@5ed1b0e57862ee6f9e429feb81e9bdf7fbc16d35
Uploaded Thu, 08 Aug 2024 17:07:49 GMT
PR commit 3551a34
Base commit 7a0c55b
Merge commit 5ed1b0e
Serial number 537591d510424899bd7c08bb3dd71eda

@goodov goodov force-pushed the display-merge-sha branch 5 times, most recently from ba348e3 to 3551a34 Compare August 8, 2024 17:06
@goodov goodov changed the title Display the actual merge SHA of the seed. Use the merge commit as seed version Aug 8, 2024
@goodov goodov marked this pull request as ready for review August 8, 2024 17:15
@goodov goodov enabled auto-merge August 8, 2024 17:17
@goodov goodov self-assigned this Aug 8, 2024
@goodov goodov added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 4f91a05 Aug 8, 2024
7 checks passed
@goodov goodov deleted the display-merge-sha branch August 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants