Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DayZeroStudyAndroid and DayZeroStudyWindows #1187

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Remove DayZeroStudyAndroid and DayZeroStudyWindows #1187

merged 1 commit into from
Aug 20, 2024

Conversation

DJAndries
Copy link
Collaborator

No description provided.

@DJAndries DJAndries requested a review from a team as a code owner August 20, 2024 16:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1187.
    Android: Set the command line to --variations-pr=1187 in debug menu, restart the browser.
    iOS: Set Variations PR to 1187 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1187@99a59c306bd1f47cdc4362cbec076e88e16dd330
Uploaded Tue, 20 Aug 2024 16:33:03 GMT
PR commit bac39e4
Base commit 6c8d43e
Merge commit 99a59c3
Serial number 3001320f5d598fc41f73f58f5ebbe91c

kjozwiak
kjozwiak approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 51aa124 Aug 20, 2024
7 checks passed
@kjozwiak kjozwiak deleted the remove-day-zero branch August 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJAndries @kjozwiak