Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes VulkanStudy on Android #1189

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Removes VulkanStudy on Android #1189

merged 1 commit into from
Aug 21, 2024

Conversation

SergeyZhukovsky
Copy link
Member

Resolves #1188
I was able to replicate a blank page on one of Motorola devices, where it falls under blocklist. Force enabling it shows the page and I haven't seen any issues with YouTube videos.

@SergeyZhukovsky SergeyZhukovsky self-assigned this Aug 20, 2024
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner August 20, 2024 18:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1189.
    Android: Set the command line to --variations-pr=1189 in debug menu, restart the browser.
    iOS: Set Variations PR to 1189 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1189@9f64714c17a2262e96a55e10b1f5981a756f6fb0
Uploaded Tue, 20 Aug 2024 18:55:25 GMT
PR commit 247b941
Base commit 93f38b1
Merge commit 9f64714
Serial number 55c9a015a9a4cb6c525e1180defc9bca

kjozwiak
kjozwiak approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Aug 21, 2024
@kjozwiak kjozwiak mentioned this pull request Aug 21, 2024
Closed
Merged via the queue into main with commit b1e31ec Aug 21, 2024
7 checks passed
@kjozwiak kjozwiak deleted the android_vulkanstudy_remove branch August 21, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove VulkanStudy on Android
2 participants
@SergeyZhukovsky @kjozwiak