Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase BraveWorkaroundNewWindowFlash rollout to 100% beta. #1198

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Increase BraveWorkaroundNewWindowFlash rollout to 100% beta. #1198

merged 1 commit into from
Aug 26, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Aug 26, 2024 •
edited
Loading

Increase userbase for #1178

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1198.
    Android: Set the command line to --variations-pr=1198 in debug menu, restart the browser.
    iOS: Set Variations PR to 1198 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1198@d020cb55a07c7a301e49a6771f1fc36e956f9fc9
Uploaded Mon, 26 Aug 2024 11:18:43 GMT
PR commit f0044b1
Base commit 1b72eb1
Merge commit d020cb5
Serial number c963b2cadc94b3f8d446cc07730758fc

@goodov goodov marked this pull request as ready for review August 26, 2024 11:19
@goodov goodov requested a review from a team as a code owner August 26, 2024 11:19
kjozwiak
kjozwiak approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit ede1c43 Aug 26, 2024
7 checks passed
@kjozwiak kjozwiak deleted the new-findow-flash-beta-100 branch August 26, 2024 17:24
@goodov goodov restored the new-findow-flash-beta-100 branch August 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @kjozwiak