Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase WebcompatExceptionsService in Release to 100% #1200

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Increase WebcompatExceptionsService in Release to 100% #1200

merged 1 commit into from
Aug 27, 2024

Conversation

arthuredelstein
Copy link
Collaborator

No description provided.

@arthuredelstein arthuredelstein requested a review from a team as a code owner August 26, 2024 18:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1200.
    Android: Set the command line to --variations-pr=1200 in debug menu, restart the browser.
    iOS: Set Variations PR to 1200 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1200@bb139acb1072e7af6f15bfeefbcc3ed7bd5dbd02
Uploaded Mon, 26 Aug 2024 18:38:57 GMT
PR commit abf5d6c
Base commit ede1c43
Merge commit bb139ac
Serial number d35660212e7f1dbc1a0baf3eb4c1f867

kjozwiak
kjozwiak approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers 👍

@kjozwiak kjozwiak added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 7fd0ce2 Aug 27, 2024
7 checks passed
@kjozwiak kjozwiak deleted the issues/1193_100 branch August 27, 2024 22:31
@goodov
Copy link
Member

goodov commented Aug 28, 2024

@arthuredelstein please enable the feature by default in brave-core. Ideally we should always do this before rolling the feature to Release channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthuredelstein @goodov @kjozwiak