Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables background playback on Android on release channel for 20 percent of users #495

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

SergeyZhukovsky
Copy link
Member

Resolves #494

@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner December 21, 2022 16:18
@SergeyZhukovsky SergeyZhukovsky self-assigned this Dec 21, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Getting this merged into main so QA can verify the above on staging before uplifting #496.

@kjozwiak kjozwiak merged commit 60b420c into main Dec 21, 2022
@kjozwiak kjozwiak deleted the android_release_bgplayback_20 branch December 21, 2022 22:38
@kjozwiak
Copy link
Member

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

Release channel

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.146 Chromium: 108.0.5359.128 (Official Build) (64-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Android 13; Build/TQ1A.221205.011

BgPlaybackStudy:Enabled

  • launched 1.46.146 Chromium: 108.0.5359.128 and ensured that Background video playback was disabled
  • restarted Brave and ensured that BgPlaybackStudy:Enabled via brave://version as the client used the pulled Griffin studies
  • ensured that Background video playback was enabled via Hamburger Menu -> Settings
  • ensured that videos on YT are still playing when Brave is moved to the background and other applications are being used
  • ensured that videos on YT are still playing when the phone has been locked
  • ensured that the video that's being played is appearing the via Notification area while the phone is locked

Before restarting Brave and pulling the studies

Example Example
Screenshot_20221222-015105 Screenshot_20221222-015123

After restarting Brave and pulling the studies

Example Example Example
Screenshot_20221222-022230 Screenshot_20221222-022237 Screenshot_20221222-022309

BgPlaybackStudy:Default

  • launched 1.46.146 Chromium: 108.0.5359.128 and ensured that Background video playback was disabled
  • restarted Brave and ensured that BgPlaybackStudy:Default via brave://version as the client used the pulled Griffin studies
  • ensured that Background video playback was disabled via Hamburger Menu -> Settings

Before restarting Brave and pulling the studies

Example Example
Screenshot_20221222-015105 Screenshot_20221222-015123

After restarting Brave and pulling the studies

Example Example
Screenshot_20221222-015208 Screenshot_20221222-015235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable background playback for 20 percent users on release channel on Android
2 participants