Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables bg playback by default for 20 percent users on release channel #526

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

SergeyZhukovsky
Copy link
Member

Resolves #525

@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 27, 2023
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner February 27, 2023 20:45
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main so QA can verify on staging before merging #527.

@kjozwiak kjozwiak merged commit 56f2d8d into main Mar 1, 2023
@kjozwiak kjozwiak deleted the android_bgplayback_release_20 branch March 1, 2023 06:34
@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2023

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

Release channel

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.48.171 Chromium: 110.0.5481.177 (Official Build) (32-bit)
--- | ---
Revision | f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS | Android 13; Build/TQ1A.230205.002

BgPlaybackStudy:Enabled

  • launched 1.48.171 Chromium: 110.0.5481.177 and ensured that Background video playback was disabled
  • restarted Brave and ensured that BgPlaybackStudy:Enabled via brave://version as the client used the pulled Griffin studies
  • ensured that Background video playback was enabled via Hamburger Menu -> Settings
  • ensured that videos on YT are still playing when Brave is moved to the background and other applications are being used
  • ensured that videos on YT are still playing when the phone has been locked
  • ensured that the video that's being played is appearing the via Notification area while the phone is locked
  • ensured that can't disable video background playback when enabled via BgPlaybackStudy brave-browser#27550 doesn't occur

Before restarting Brave and pulling the studies

Example Example
Screenshot_20230308-235110 Screenshot_20230308-235119

After restarting Brave and pulling the studies

Example Example Example Example
Screenshot_20230308-235452 Screenshot_20230308-235502 Screenshot_20230308-235604 Screenshot_20230308-235719

BgPlaybackStudy:Default

Before restarting Brave and pulling the studies

Example Example
Screenshot_20230308-235110 Screenshot_20230308-235119

After restarting Brave and pulling the studies

Example Example
Screenshot_20230308-235201 Screenshot_20230308-235207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable background playback for 20 percent users on release channel on Android
2 participants