Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Speedreader on Android for all users on nightly and beta channels #565

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

SergeyZhukovsky
Copy link
Member

Resolves #564

@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner March 21, 2023 16:15
@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 21, 2023
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging into main so QA can run through the above on staging before uplifting/merging #566 into production.

@kjozwiak kjozwiak merged commit 1a40f0b into main Mar 30, 2023
@kjozwiak kjozwiak deleted the android_speedreader branch March 30, 2023 20:50
@kjozwiak
Copy link
Member

kjozwiak commented Mar 31, 2023

Android verifications on Nightly

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Used the STR/Cases outlined via #564 (comment) as a guideline for the test cases that I ran through below.

Pixel 6 running Android 13 Test Cases using Nightly

SpeedreaderAndroidStudy:Enabled

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.52.5 Chromium: 112.0.5615.49 (Official Build) canary (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230305.008.E1
  • launched 1.52.5 Chromium: 112.0.5615.49 and ensured that SpeedreaderAndroidStudy wasn't visible under brave://version
  • restarted the browser and ensured that SpeedreaderAndroidStudy:Enabled via brave://version
  • visited several articles under cnn.com & nyt.com and ensured that the articles were not being loaded in reader mode
  • ensured that Enable Speedreader is disabled by default via Settings -> Appearance
  • enabled Enable Speedreader via Settings -> Appearance
  • visited several articles and ensured that they were loading in reader mode due to Speedreader being enabled
  • ensured that disabling Speedreader worked without any issues and articles stopped loading in reader mode
  • ensured that restarting the browser several times didn't change the current state (Disabled/Enabled Speedreader)
  • ensured that View original within an article that's in Reader Mode loads the original website without any issues
Example Example Example Example Example Example Example
Screenshot_20230330-213850 Screenshot_20230330-213910 Screenshot_20230330-214233 Screenshot_20230330-214237 Screenshot_20230330-215425 Screenshot_20230330-214316 Screenshot_20230330-214652

Pixel 6 running Android 13 Test Cases using BETA

SpeedreaderAndroidStudy:Enabled

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.51.71 Chromium: 112.0.5615.39 (Official Build) beta (32-bit)
--- | ---
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Android 13; Build/TQ2A.230305.008.E1
  • launched 1.51.71 Chromium: 112.0.5615.39 and ensured that SpeedreaderAndroidStudy wasn't visible under brave://version
  • restarted the browser and ensured that SpeedreaderAndroidStudy:Enabled via brave://version
  • visited several articles under cnn.com & nyt.com and ensured that the articles were not being loaded in reader mode
  • ensured that Enable Speedreader is disabled by default via Settings -> Appearance
  • enabled Enable Speedreader via Settings -> Appearance
  • visited several articles and ensured that they were loading in reader mode due to Speedreader being enabled
  • ensured that disabling Speedreader worked without any issues and articles stopped loading in reader mode
  • ensured that restarting the browser several times didn't change the current state (Disabled/Enabled Speedreader)
  • ensured that View original within an article that's in Reader Mode loads the original website without any issues
Example Example Example Example Example Example Example
Screenshot_20230331-023142 Screenshot_20230331-023207 Screenshot_20230331-023219 Screenshot_20230331-023223 Screenshot_20230331-023235 Screenshot_20230331-023311 Screenshot_20230331-023401

Pixel 6 running Android 13 Test Cases using Release

SpeedreaderAndroidStudy not being used/visible under brave://version

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.132 Chromium: 111.0.5563.147 (Official Build) (32-bit)
--- | ---
Revision | 029fd65a4dd711d1078468ed2206999cec86066b-refs/branch-heads/5563@{#1239}
OS | Android 13; Build/TQ2A.230305.008.E1
  • launched 1.49.132 Chromium: 111.0.5563.147 and ensured that SpeedreaderAndroidStudy wasn't visible under brave://version
  • restarted the browser and ensured that SpeedreaderAndroidStudy:Enabled isn't visible via brave://version
  • ensure that Speedreader toggle isn't available via Settings -> Appearance
Example Example
Screenshot_20230331-115656 Screenshot_20230331-120852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable speedreader flag on Android for nightly and beta channels
2 participants