-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables Speedreader on Android for all users on nightly and beta channels #565
Conversation
56dfa1f
to
58a307c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging into main
so QA can run through the above on staging
before uplifting/merging #566 into production
.
58a307c
to
7f407db
Compare
|
Example |
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Pixel 6
running Android 13
Test Cases using BETA
SpeedreaderAndroidStudy:Enabled
Verification PASSED on Pixel 6
running Android 13
using the following build(s):
Brave | 1.51.71 Chromium: 112.0.5615.39 (Official Build) beta (32-bit)
--- | ---
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Android 13; Build/TQ2A.230305.008.E1
- launched
1.51.71 Chromium: 112.0.5615.39
and ensured thatSpeedreaderAndroidStudy
wasn't visible underbrave://version
- restarted the browser and ensured that
SpeedreaderAndroidStudy:Enabled
viabrave://version
- visited several articles under cnn.com & nyt.com and ensured that the articles were not being loaded in reader mode
- ensured that
Enable Speedreader
is disabled by default viaSettings
->Appearance
- enabled
Enable Speedreader
viaSettings
->Appearance
- visited several articles and ensured that they were loading in reader mode due to
Speedreader
being enabled - ensured that disabling
Speedreader
worked without any issues and articles stopped loading in reader mode - ensured that restarting the browser several times didn't change the current state (Disabled/Enabled Speedreader)
- ensured that
View original
within an article that's inReader Mode
loads the original website without any issues
Example |
Example |
Example |
Example |
Example |
Example |
Example |
---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Pixel 6
running Android 13
Test Cases using Release
SpeedreaderAndroidStudy
not being used/visible under brave://version
Verification PASSED on Pixel 6
running Android 13
using the following build(s):
Brave | 1.49.132 Chromium: 111.0.5563.147 (Official Build) (32-bit)
--- | ---
Revision | 029fd65a4dd711d1078468ed2206999cec86066b-refs/branch-heads/5563@{#1239}
OS | Android 13; Build/TQ2A.230305.008.E1
- launched
1.49.132 Chromium: 111.0.5563.147
and ensured thatSpeedreaderAndroidStudy
wasn't visible underbrave://version
- restarted the browser and ensured that
SpeedreaderAndroidStudy:Enabled
isn't visible viabrave://version
- ensure that
Speedreader
toggle isn't available viaSettings
->Appearance
Example |
Example |
---|---|
![]() |
![]() |
Resolves #564