Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable aggressive fingerprinting mode in Beta (#966) #967

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Disable aggressive fingerprinting mode in Beta (#966) #967

merged 1 commit into from
Mar 27, 2024

Conversation

arthuredelstein
Copy link
Collaborator

No description provided.

@arthuredelstein arthuredelstein requested a review from a team as a code owner March 25, 2024 18:09
kjozwiak
kjozwiak approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging and then we'll get #968 pushed into production.

@kjozwiak kjozwiak merged commit 7335b7a into main Mar 27, 2024
5 checks passed
@kjozwiak kjozwiak deleted the issues/main_966 branch March 27, 2024 16:27
@kjozwiak
Copy link
Member

kjozwiak commented Mar 28, 2024 •
edited
Loading

Win 11 x64 verifications

Quick note: The following basically ensured that Aggressive Fingerprinting is being removed via BraveAggressiveModeRetirementExperiment. The functionality of the feature was QA'd/verified more thoroughly via brave/brave-browser#31229 as per brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment) & brave/brave-browser#31229 (comment).

The study was also checked/verified on Nightly via #866 (comment) & #866 (comment) when we went live.

BETA - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.95 Chromium: 123.0.6312.86 (Official Build) beta (64-bit)
-- | --
Revision | ef0da42c66f8e52af0783c9f8393035a88249c10
OS | Windows 11 Version 23H2 (Build 22631.3374)
  • downloaded/installed 1.65.95 Chromium: 123.0.6312.86 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
image image image

Release - BraveAggressiveModeRetirementExperiment not being used

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.113 Chromium: 123.0.6312.86 (Official Build) (64-bit)
-- | --
Revision | 4e20399c0c5e3cbbb80dd1119122400e08259feb
OS | Windows 11 Version 23H2 (Build 22631.3374)
  • downloaded/installed 1.64.113 Chromium: 123.0.6312.86 (standalone executable) and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
image image image

@kjozwiak
Copy link
Member

Pixel 6 Android 14 Verifications

Quick note: The following basically ensured that Aggressive Fingerprinting is being removed via BraveAggressiveModeRetirementExperiment. The functionality of the feature was QA'd/verified more thoroughly via brave/brave-browser#31229 as per brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment), brave/brave-browser#31229 (comment) & brave/brave-browser#31229 (comment).

The study was also checked/verified on Nightly via #866 (comment) & #866 (comment) when we went live.

BETA - BraveAggressiveModeRetirementExperiment:Disabled

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.65.95 Chromium: 123.0.6312.86 (Official Build) beta (64-bit)
--- | ---
Revision | ef0da42c66f8e52af0783c9f8393035a88249c10
OS | Android 14; Build/AP21.240216.010; 34; REL
  • downloaded/installed 1.65.95 Chromium: 123.0.6312.86 and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment:Disabled via brave://version
  • ensured that Block fingerprinting is now a toggle via the shields panel
    • ensured that Aggressively block fingerprinting isn't visible/selectable
  • ensured that Block fingerprinting is now a toggle via brave://settings/shields
    • ensured that Strict, may break sites isn't visible/selectable
Example Example Example
Screenshot_20240328-004352 Screenshot_20240328-004425 Screenshot_20240328-004438

Release - BraveAggressiveModeRetirementExperiment not being used

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.64.109 Chromium: 123.0.6312.58 (Official Build) (64-bit)
--- | ---
Revision | ded360c0dc8a4bd8aecb9cbe32a7aa4477d42246
OS | Android 14; Build/AP21.240216.010; 34; REL
  • downloaded/installed 1.64.109 Chromium: 123.0.6312.58 and started Brave
  • ensured that BraveAggressiveModeRetirementExperiment isn't visible under brave://version
  • ensured that Aggressively block fingerprinting is still visible via the Fingerprinting dropdown via the shields panel
  • ensured that Strict, may break sites still exists under Block fingerprinting via brave://settings/shields
Example Example Example
Screenshot_20240328-005357 Screenshot_20240328-005417 Screenshot_20240328-005432

@kjozwiak kjozwiak mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthuredelstein @kjozwiak