Change x mark by shouldComponentUpdate

js/about/preferences.js

@@ -163,26 +163,13 @@ class GeneralTab extends ImmutableComponent {
   }
 }
 
-class SearchSelectEntry extends React.Component {
-  constructor (props) {
-    super(props)
-    this.state = {
-      select: props.name === getSetting(settings.DEFAULT_SEARCH_ENGINE)
-    }
-
-    ipc.on(messages.SETTINGS_UPDATED, (e, settings) => {
-      const settingsMap = Immutable.fromJS(settings || {})
-      if (this.props.name === settingsMap.get('search.default-search-engine')) {
-        this.setState({select: true})
-      } else {
-        this.setState({select: false})
-      }
-    })
+class SearchSelectEntry extends ImmutableComponent {
+  shouldComponentUpdate (nextProps, nextState) {
+    return this.props.settings.get('search.default-search-engine') !== nextProps.settings.get('search.default-search-engine')
   }
-
   render () {
     return <div>
-    {this.state.select ? 'x' : ''}
+    {this.props.settings.get('search.default-search-engine') === this.props.name ? 'x' : ''}
     </div>
   }
 }
@@ -224,7 +211,7 @@ class SearchTab extends ImmutableComponent {
         paddingLeft: '5px',
         verticalAlign: 'middle'
       }
-      array.push([<SearchSelectEntry name={entry.name} />,
+      array.push([<SearchSelectEntry name={entry.name} settings={this.props.settings} />,
         <SearchEntry name={entry.name} iconStyle={iconStyle} textStyle={textStyle}
           onChangeSetting={this.props.onChangeSetting} />,
         <SearchShortcutEntry shortcut={entry.shortcut} textStyle={textStyle} />])