Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Make ia32 Brave.exe squirrel aware
Browse files Browse the repository at this point in the history
This avoids special squirrel handling when no exes are squirrel aware. The special handling in question is completely broken when there are more than 1 exe

Fix #6313

Auditors: @aekeus
  • Loading branch information
bbondy committed Jan 17, 2017
1 parent 0166c87 commit 0bd01d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/buildPackage.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ if (isLinux) {
cmds.push('makensis.exe -DARCH=' + arch + ' res/braveDefaults.nsi')
cmds.push('ncp ./app/extensions ' + path.join(buildDir, 'resources', 'extensions'))
// Make sure the Brave.exe binary is squirrel aware so we get squirrel events and so that Squirrel doesn't auto create shortcuts.
cmds.push('"node_modules/rcedit/bin/rcedit.exe" ./Brave-win32-x64/Brave.exe --set-version-string "SquirrelAwareVersion" "1"')
cmds.push('"node_modules/rcedit/bin/rcedit.exe" ./Brave-win32-' + arch + '/Brave.exe --set-version-string "SquirrelAwareVersion" "1"')
}

cmds.push('mkdirp ' + path.join(buildDir, 'resources', 'app.asar.unpacked', 'node_modules', 'spellchecker', 'vendor', 'hunspell_dictionaries'))
Expand Down

1 comment on commit 0bd01d0

@aekeus
Copy link
Member

@aekeus aekeus commented on 0bd01d0 Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.