Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add the same underscore.string dep as ledger-publisher
Browse files Browse the repository at this point in the history
Auditors: @bridiver

Fix #7911

It turns out we did have an underscore-string dep top level from argparse, but it was old, and it had a different directory hierarchy.
It had trim under lib, and package.json specified that as the main entry
point, but our electron resolver doesn't check that.

The underscore.string that ledger-parser uses is newer and has the deps directly under underscore.string without a lib folder.
By adding the dep top level, we can ensure we use the later version
which doesn't have an extra directory that our resolver doesn't
understand.
  • Loading branch information
bbondy authored and bridiver committed Apr 4, 2017
1 parent 6d0ce5b commit 27bfd1a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@
"tldjs": "1.6.2",
"tracking-protection": "1.1.x",
"underscore": "1.8.3",
"underscore.string": "^3.3.4",
"url-loader": "^0.5.7",
"webtorrent-remote": "^1.0.0"
},
Expand Down

0 comments on commit 27bfd1a

Please sign in to comment.