Merge pull request #6324 from luixxiul/fix-buttons-margin

Small fixes of buttons on about:certerror and .noScriptInfo
brave · Dec 21, 2016 · 3d1db35 · 3d1db35
2 parents 1d8b913 + 98217b3
commit 3d1db35
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 6 deletions.
diff --git a/js/about/certerror.js b/js/about/certerror.js
@@ -138,10 +138,9 @@ class CertErrorPage extends React.Component {
       <div className='buttons'>
         <Button l10nId='certErrorSafety' className='actionButton' onClick={this.onSafety.bind(this)} />
         {this.state.url ? (this.state.advanced
-          ? (<div>
-            <Button l10nId='certErrorButtonText' className='subtleButton' onClick={this.onAccept.bind(this)} />
-            <Button l10nId='certErrorShowCertificate' className='subtleButton' onClick={this.onDetail.bind(this)} />
-          </div>)
+          ? (<Button l10nId='certErrorButtonText' className='subtleButton' onClick={this.onAccept.bind(this)} />) : null) : null}
+        {this.state.url ? (this.state.advanced
+          ? (<Button l10nId='certErrorShowCertificate' className='subtleButton' onClick={this.onDetail.bind(this)} />)
           : <Button l10nId='certErrorAdvanced' className='subtleButton' onClick={this.onAdvanced.bind(this)} />) : null}
       </div>
     </div>

diff --git a/js/components/noScriptInfo.js b/js/components/noScriptInfo.js
@@ -64,7 +64,7 @@ class NoScriptInfo extends ImmutableComponent {
       site: this.props.frameProps.get('location') || 'this page'
     }
     return <Dialog onHide={this.props.onHide} className='noScriptInfo' isClickDismiss>
-      <div>
+      <div className='dialogInner'>
         <div className='truncate' data-l10n-args={JSON.stringify(l10nArgs)}
           data-l10n-id={this.numberBlocked === 1 ? 'scriptBlocked' : 'scriptsBlocked'} />
         {this.buttons}

diff --git a/less/about/error.less b/less/about/error.less
@@ -20,6 +20,18 @@
         padding-bottom: 1rem;
       }
 
+      .buttons {
+        display: flex;
+        flex-flow: row wrap;
+        position: relative;
+        right: .2em; // cancel margin: .2em to align .buttons and .certErrorText
+
+        > .browserButton {
+          margin: .2em;
+          font-size: 14px;
+        }
+      }
+
       .errorLogo {
         margin-bottom: 2rem;
 

diff --git a/less/forms.less b/less/forms.less
@@ -515,14 +515,18 @@ select {
 }
 
 .noScriptInfo {
-  >div {
+  .dialogInner {
     .flyoutDialog;
     right: 20px;
     width: auto;
     max-width: 350px;
     text-align: center;
     font-size: 15px;
     cursor: default;
+
+    .truncate {
+      margin-bottom: 5px;
+    }
   }
 }