Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Merge pull request #6080 from luixxiul/community
Browse files Browse the repository at this point in the history
[WiP] Advertise community.brave.com
  • Loading branch information
bbondy authored Dec 13, 2016
2 parents 1597632 + 911ba30 commit 3f09030
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 43 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ To download the latest release, [see our releases page](https://github.com/brave

For a more user-friendly download page, [please visit our website](https://brave.com/downloads.html).

## Community

[The Brave Community](https://community.brave.com/)

## Useful documentation

* See [CONTRIBUTING.md](.github/CONTRIBUTING.md) for tips and guidelines about contributing.
Expand Down
9 changes: 5 additions & 4 deletions app/common/commonMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const Immutable = require('immutable')
const locale = require('../../js/l10n')
const settings = require('../../js/constants/settings')
const getSetting = require('../../js/settings').getSetting
const issuesUrl = 'https://github.com/brave/browser-laptop/issues'
const communityURL = 'https://community.brave.com/'
const isDarwin = process.platform === 'darwin'

let electron
Expand Down Expand Up @@ -260,16 +260,17 @@ module.exports.reportAnIssueMenuItem = () => {
label: locale.translation('reportAnIssue'),
click: function (item, focusedWindow) {
module.exports.sendToFocusedWindow(focusedWindow,
[messages.SHORTCUT_NEW_FRAME, issuesUrl])
[messages.SHORTCUT_NEW_FRAME, communityURL])
}
}
}

module.exports.submitFeedbackMenuItem = () => {
return {
label: locale.translation('submitFeedback'),
click: function () {
appActions.submitFeedback()
click: function (item, focusedWindow) {
module.exports.sendToFocusedWindow(focusedWindow,
[messages.SHORTCUT_NEW_FRAME, communityURL])
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/extensions/brave/locales/en-US/preferences.properties
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ hintsTitle=Helpful hints
hint0=The Bravery panel allows you to turn HTTPS Everywhere on or off. HTTPS Everywhere automatically changes your HTTP traffic to HTTPS for supported sites to keep you more secure.
hint1=Brave will always auto-update for you, but you can check for an update on demand in the menu.
hint2=The File menu allows you to create a New Session Tab. Session tabs are like any other tab but they run in a different user profile. This allows you to login to the same sites multiple times with the same browser.
sendUsFeedback=Send us feedback
submitFeedback=Submit Feedback
loveToHear=We'd love to hear from you.
startsWith=Brave starts with
startsWithOptionLastTime=My windows / tabs from last time
Expand Down
6 changes: 0 additions & 6 deletions docs/appActions.md
Original file line number Diff line number Diff line change
Expand Up @@ -472,12 +472,6 @@ Dispatches a message when the network is disconnected



### submitFeedback()

Dispatches a message to submit feedback



### defaultBrowserUpdated(useBrave)

Dispatch a message to set default browser
Expand Down
9 changes: 0 additions & 9 deletions js/about/aboutActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -306,15 +306,6 @@ const aboutActions = {
})
},

/**
* Dispatches a message to submit feedback
*/
submitFeedback: function () {
aboutActions.dispatchAction({
actionType: appConstants.APP_SUBMIT_FEEDBACK
})
},

/**
* Show the "Add Bookmark" control
* @param {Object} siteDetail - object bound to add/edit control
Expand Down
2 changes: 1 addition & 1 deletion js/about/preferences.js
Original file line number Diff line number Diff line change
Expand Up @@ -1703,7 +1703,7 @@ class HelpfulHints extends ImmutableComponent {
</span>
<div data-l10n-id={`hint${this.props.hintNumber}`} />
<div className='helpfulHintsBottom'>
<a data-l10n-id='sendUsFeedback' onClick={aboutActions.submitFeedback} />
<a target='_blank' href='https://community.brave.com/' data-l10n-id='submitFeedback' />
</div>
</div>
}
Expand Down
9 changes: 0 additions & 9 deletions js/actions/appActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -551,15 +551,6 @@ const appActions = {
})
},

/**
* Dispatches a message to submit feedback
*/
submitFeedback: function () {
AppDispatcher.dispatch({
actionType: AppConstants.APP_SUBMIT_FEEDBACK
})
},

/**
* Dispatch a message to set default browser
*
Expand Down
1 change: 0 additions & 1 deletion js/constants/appConstants.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const AppConstants = {
APP_SET_MENUBAR_TEMPLATE: _,
APP_UPDATE_ADBLOCK_DATAFILES: _,
APP_UPDATE_ADBLOCK_CUSTOM_RULES: _,
APP_SUBMIT_FEEDBACK: _,
APP_DEFAULT_BROWSER_UPDATED: _,
APP_DEFAULT_BROWSER_CHECK_COMPLETE: _,
APP_POPULATE_HISTORY: _,
Expand Down
12 changes: 0 additions & 12 deletions js/stores/appStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ const diff = require('immutablediff')
const debounce = require('../lib/debounce.js')
const locale = require('../../app/locale')
const path = require('path')
const {channel} = require('../../app/channel')
const os = require('os')
const autofill = require('../../app/autofill')

// state helpers
Expand Down Expand Up @@ -762,16 +760,6 @@ const handleAppAction = (action) => {
})
return
}
case AppConstants.APP_SUBMIT_FEEDBACK:
let platform = os.platform()
if (platform === 'darwin') {
platform = 'macOS'
} else if (platform === 'windows') {
platform = 'Windows'
}
const subject = encodeURIComponent(`Brave ${platform} ${os.arch()} ${app.getVersion()}${channel()} feedback`)
electron.shell.openExternal(`${appConfig.contactUrl}?subject=${subject}`)
break
case AppConstants.APP_DEFAULT_BROWSER_UPDATED:
if (action.useBrave) {
for (const p of defaultProtocols) {
Expand Down

0 comments on commit 3f09030

Please sign in to comment.