Set true user agent on adobe domains

Auditors: @bbondy
brave · Jun 27, 2016 · 811e742 · 811e742 · bbondy · Jul 2, 2016
1 parent 3a6b80a
commit 811e742
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/app/filtering.js b/app/filtering.js
@@ -158,6 +158,7 @@ function registerForBeforeSendHeaders (session) {
     }
 
     let requestHeaders = details.requestHeaders
+    let parsedUrl = urlParse(details.url || '')
 
     if (!spoofedUserAgent) {
       // To minimize fingerprintability, remove Brave from the UA string.
@@ -167,7 +168,9 @@ function registerForBeforeSendHeaders (session) {
       appActions.changeSetting(settings.USERAGENT, spoofedUserAgent)
     }
 
-    requestHeaders['User-Agent'] = spoofedUserAgent
+    if (!appConfig.uaExceptionHosts.includes(parsedUrl.hostname)) {
+      requestHeaders['User-Agent'] = spoofedUserAgent
+    }
 
     for (let i = 0; i < beforeSendHeadersFilteringFns.length; i++) {
       let results = beforeSendHeadersFilteringFns[i](details)
@@ -183,7 +186,6 @@ function registerForBeforeSendHeaders (session) {
       }
     }
 
-    let parsedUrl = urlParse(details.url || '')
     if (module.exports.isResourceEnabled(appConfig.resourceNames.COOKIEBLOCK, details.firstPartyUrl)) {
       if (module.exports.isThirdPartyHost(urlParse(details.firstPartyUrl || '').hostname,
                                           parsedUrl.hostname)) {

diff --git a/js/components/frame.js b/js/components/frame.js
@@ -28,6 +28,7 @@ const consoleStrings = require('../constants/console')
 const { aboutUrls, isSourceAboutUrl, isTargetAboutUrl, getTargetAboutUrl, getBaseUrl } = require('../lib/appUrlUtil')
 const { isFrameError } = require('../lib/errorUtil')
 const locale = require('../l10n')
+const appConfig = require('../constants/appConfig')
 
 class Frame extends ImmutableComponent {
   constructor () {
@@ -142,9 +143,11 @@ class Frame extends ImmutableComponent {
     }
     this.webview.setAttribute('allowDisplayingInsecureContent', true)
     this.webview.setAttribute('data-frame-key', this.props.frame.get('key'))
-    this.webview.setAttribute('useragent', getSetting(settings.USERAGENT) || '')
 
     const parsedUrl = urlParse(location)
+    if (!appConfig.uaExceptionHosts.includes(parsedUrl.hostname)) {
+      this.webview.setAttribute('useragent', getSetting(settings.USERAGENT) || '')
+    }
     const hack = siteHacks[parsedUrl.hostname]
     if (hack && hack.userAgent) {
       this.webview.setAttribute('useragent', hack.userAgent)

diff --git a/js/constants/appConfig.js b/js/constants/appConfig.js
@@ -106,5 +106,8 @@ module.exports = {
     'general.disable-title-mode': process.platform === 'win32',
     'advanced.hardware-acceleration-enabled': true,
     'advanced.default-zoom-level': null
-  }
+  },
+  uaExceptionHosts: [
+    'get.adobe.com', 'adobe.com', 'www.adobe.com', 'helpx.adobe.com'
+  ] // hosts to send true UA to
 }