Remove check for update menu item on Linux

Fix #7529 Auditors: @aekeus
brave · Mar 8, 2017 · 9811351 · 9811351 · aekeus · Mar 8, 2017
1 parent ce004b9
commit 9811351
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/app/browser/menu.js b/app/browser/menu.js
@@ -26,6 +26,7 @@ const getSetting = require('../../js/settings').getSetting
 const locale = require('../locale')
 const {isSiteBookmarked, siteSort} = require('../../js/state/siteUtil')
 const isDarwin = process.platform === 'darwin'
+const isLinux = process.platform === 'linux'
 const aboutUrl = 'https://brave.com/'
 
 let appMenu = null
@@ -437,9 +438,11 @@ const createHelpSubmenu = () => {
     }
   ]
 
-  if (!isDarwin) {
+  if (!isDarwin && !isLinux) {
     submenu.push(CommonMenu.separatorMenuItem)
     submenu.push(CommonMenu.checkForUpdateMenuItem())
+  }
+  if (!isDarwin) {
     submenu.push(CommonMenu.separatorMenuItem)
     submenu.push(CommonMenu.aboutBraveMenuItem())
   }

diff --git a/js/contextMenus.js b/js/contextMenus.js
@@ -41,6 +41,7 @@ const extensionActions = require('../app/common/actions/extensionActions')
 const appStore = require('./stores/appStoreRenderer')
 
 const isDarwin = process.platform === 'darwin'
+const isLinux = process.platform === 'linux'
 
 /**
  * Obtains an add bookmark menu item
@@ -687,6 +688,19 @@ function getEditableItems (selection, editFlags, hasFormat) {
 }
 
 function hamburgerTemplateInit (location, e) {
+  const helpSubmenu = [
+    CommonMenu.aboutBraveMenuItem(),
+    CommonMenu.separatorMenuItem
+  ]
+
+  if (!isLinux) {
+    helpSubmenu.push(
+      CommonMenu.checkForUpdateMenuItem(),
+      CommonMenu.separatorMenuItem)
+  }
+
+  helpSubmenu.push(CommonMenu.submitFeedbackMenuItem())
+
   const template = [
     CommonMenu.newTabMenuItem(),
     CommonMenu.newPrivateTabMenuItem(),
@@ -740,13 +754,7 @@ function hamburgerTemplateInit (location, e) {
     CommonMenu.separatorMenuItem,
     {
       label: locale.translation('help'),
-      submenu: [
-        CommonMenu.aboutBraveMenuItem(),
-        CommonMenu.separatorMenuItem,
-        CommonMenu.checkForUpdateMenuItem(),
-        CommonMenu.separatorMenuItem,
-        CommonMenu.submitFeedbackMenuItem()
-      ]
+      submenu: helpSubmenu
     },
     CommonMenu.quitMenuItem()
   ]