This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auditors: @diracdeltas
- Loading branch information
Showing
2 changed files
with
11 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
const Brave = require('./lib/brave') | ||
const Config = require('../js/constants/config').default | ||
const {urlInput, activeWebview, activeTabFavicon, activeTab, navigatorLoadTime, urlbarIcon} = require('./lib/selectors') | ||
const urlParse = require('url').parse | ||
const assert = require('assert') | ||
|
||
describe('urlbar', function () { | ||
|
@@ -58,14 +59,16 @@ describe('urlbar', function () { | |
|
||
before(function *() { | ||
this.page1Url = Brave.server.url('page1.html') | ||
this.host = urlParse(this.page1Url).host | ||
yield setup(this.app.client) | ||
yield navigate(this.app.client, this.page1Url) | ||
yield this.app.client.waitForValue(urlInput) | ||
}) | ||
|
||
it('has title mode', function *() { | ||
const host = this.host | ||
yield this.app.client.waitUntil(function () { | ||
return this.getValue(urlInput).then(val => val === 'Page 1') | ||
return this.getValue(urlInput).then(val => val === host + ' | Page 1') | ||
This comment has been minimized.
Sorry, something went wrong.
diracdeltas
Member
|
||
}) | ||
.isExisting(navigatorLoadTime).then(isExisting => assert(!isExisting)) | ||
}) | ||
|
1 comment
on commit a6776d0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made these fixes already in my version of this commit, so no need for you to fix. i'll push it now.
should probably check if host is null/empty