Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add proper label to session icon on hover
Browse files Browse the repository at this point in the history
Auditors: @luixxiul
Fix #10464
Test Plan:
  • Loading branch information
cezaraugusto committed Sep 14, 2017
1 parent 86d57fc commit c52fce3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/renderer/components/tabs/content/newSessionIcon.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class NewSessionIcon extends React.Component {
data-test-id='newSessionIcon'
className={css(styles.newSession__icon, newSessionProps.newSession__indicator)}
symbolContent={this.props.partitionNumber}
l10nArgs={this.props.partitionNumber}
l10nArgs={{partitionNumber: this.props.partitionNumber}}
l10nId='sessionInfoTab'
/>
}
Expand Down

2 comments on commit c52fce3

@luixxiul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually cannot confirm this, as when you hover the mouse over the number icon, it is replaced with the close button soon.

@cezaraugusto
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep you have to resize the window up to a point that the close icon is fixed, then you hover over a partitioned tab to see the tooltip

Please sign in to comment.