Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
Auditors: @diracdeltas
  • Loading branch information
bbondy committed Aug 10, 2016
1 parent db7e059 commit ec4772a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 1 addition & 4 deletions app/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ const messages = require('../js/constants/messages')
const settings = require('../js/constants/settings')
const dialog = electron.dialog
const appActions = require('../js/actions/appActions')
const siteUtil = require('../js/state/siteUtil')
const getSetting = require('../js/settings').getSetting
const appStore = require('../js/stores/appStore')
const locale = require('./locale')

const isDarwin = process.platform === 'darwin'
Expand Down Expand Up @@ -390,7 +388,6 @@ const init = (settingsState, args) => {
{
label: locale.translation('clearHistory'),
accelerator: 'Shift+CmdOrCtrl+Delete',
enabled: siteUtil.hasNoTagSites(appStore.getState().get('sites')),
click: function (item, focusedWindow) {
CommonMenu.sendToFocusedWindow(focusedWindow, [messages.SHORTCUT_OPEN_CLEAR_BROWSING_DATA_PANEL, {browserHistory: true}])
}
Expand All @@ -402,7 +399,7 @@ const init = (settingsState, args) => {
}, {
label: locale.translation('clearSiteData'),
click: function (item, focusedWindow) {
CommonMenu.sendToFocusedWindow(focusedWindow, [messages.SHORTCUT_OPEN_CLEAR_BROWSING_DATA_PANEL, {allSiteCookies: true}])
CommonMenu.sendToFocusedWindow(focusedWindow, [messages.SHORTCUT_OPEN_CLEAR_BROWSING_DATA_PANEL, {allSiteCookies: true, cachedImagesAndFiles: true}])
}
}
]
Expand Down
1 change: 1 addition & 0 deletions docs/state.md
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ WindowStore
},
tabs: {
tabPageIndex: number, // Index of the current tab page
previewTabPageIndex: number // Index of the tab being previewed
},
siteInfo: {
isVisible: boolean // Whether or not to show site info like # of blocked ads
Expand Down

1 comment on commit ec4772a

@diracdeltas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.