Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Specific tab closing steps makes the active tab to set the wrong index #10038

Closed
cezaraugusto opened this issue Jul 18, 2017 · 8 comments · Fixed by #10640
Closed

Specific tab closing steps makes the active tab to set the wrong index #10038

cezaraugusto opened this issue Jul 18, 2017 · 8 comments · Fixed by #10640
Assignees
@bbondy
Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.18.x Hotfix 1 (...

Comments

@cezaraugusto
Copy link
Contributor

STR:

  1. Open 4 tabs
  2. Set 3rd to active
  3. Close 1st tab

Expected is that the active tab is set to 2nd but instead it keeps on the 3rd position.

cc @brave/release-team for milestone triage.
@cezaraugusto
Copy link
Contributor Author

may be related #9671, #9083

@bsclifton bsclifton added this to the 0.18.x (Release Channel) milestone Jul 19, 2017
@bsclifton
Copy link
Member

This happens all the time; moving to 0.18.x

@Jacalz
Copy link
Contributor

Jacalz commented Jul 22, 2017 •
edited
Loading

Is this the same as #9096 ?

@bbondy
Copy link
Member

bbondy commented Jul 23, 2017

How are you closing the tab in Step 3. Do you set the 1st tab as active first or using right click and close?

@cndouglas
Copy link

Closing the first tab with the tab's x button reproduces for me.

@bbondy
Copy link
Member

bbondy commented Jul 24, 2017

I'm fairly sure the index work I'm doing in #10095 will also solve this. But there are several problems with it. I'm working through them in that PR.

@cezaraugusto
Copy link
Contributor Author

I hover over the first tab and close by click. No other active tab is set other than step 2

@bbondy bbondy modified the milestones: 0.18.x hotfix, 0.18.x (Beta Channel) Jul 25, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x (Beta Channel), 0.18.x Hotfix Aug 8, 2017
@bsclifton bsclifton mentioned this issue Aug 16, 2017
Closed
@cndouglas cndouglas mentioned this issue Aug 16, 2017
Closed
@cndouglas
Copy link

Maybe related: #9385

@bbondy bbondy modified the milestones: 0.18.x Hotfix, 0.19.x (Beta Channel) Aug 17, 2017
bbondy added a commit that referenced this issue Aug 23, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
95455e7 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
@bbondy bbondy mentioned this issue Aug 23, 2017
Closed
8 tasks
bbondy added a commit that referenced this issue Aug 23, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
cc82589 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
@bbondy bbondy mentioned this issue Aug 23, 2017
Merged
8 tasks
bbondy added a commit to brave/muon that referenced this issue Aug 23, 2017
@bbondy
Use tab strip to control indexes in browser process
f526b9d 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
@bbondy bbondy mentioned this issue Aug 23, 2017
Merged
bridiver pushed a commit to brave/muon that referenced this issue Aug 23, 2017
@bbondy @bridiver
Use tab strip to control indexes in browser process
6e9eea7 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
bbondy added a commit that referenced this issue Aug 23, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
5805ca0 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
@cndouglas cndouglas mentioned this issue Aug 23, 2017
Closed
bridiver pushed a commit to brave/muon that referenced this issue Aug 23, 2017
@bbondy @bridiver
Use tab strip to control indexes in browser process
f3f5212 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
bbondy added a commit that referenced this issue Aug 30, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
c008832 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
bbondy added a commit that referenced this issue Aug 30, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
45da478 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
bbondy added a commit that referenced this issue Aug 31, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
0dbbf25 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
@bbondy bbondy mentioned this issue Aug 31, 2017
Merged
8 tasks
bbondy added a commit that referenced this issue Aug 31, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
608a71d 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
bbondy added a commit that referenced this issue Aug 31, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
22a1c33 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
bbondy added a commit that referenced this issue Aug 31, 2017
@bbondy
Use muon's tab_strip_model for driving index and active
35ea802 
Fix #10436
Fix #9385
Fix #9722
Fix #10561
Fix #9083
Fix #9671
Fix #10038
Fix #10384
Fix #10532

and probably several others.
@bbondy bbondy closed this as completed Aug 31, 2017
This was referenced Aug 31, 2017
Closed
Closed
Closed
Closed
This was referenced Aug 31, 2017
Closed
Closed
Closed
Closed
bbondy added a commit to brave/muon that referenced this issue Aug 31, 2017
@bbondy
Use tab strip to control indexes in browser process
43b75d4 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
bbondy added a commit to brave/muon that referenced this issue Aug 31, 2017
@bbondy
Use tab strip to control indexes in browser process
9bceaa8 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
bridiver pushed a commit to brave/muon that referenced this issue Sep 1, 2017
@bbondy @bridiver
Use tab strip to control indexes in browser process
e4d481f 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
bridiver pushed a commit to brave/muon that referenced this issue Oct 4, 2017
@bbondy @bridiver
Use tab strip to control indexes in browser process
63f72d7 
brave/browser-laptop#10436
brave/browser-laptop#10436
brave/browser-laptop#9385
brave/browser-laptop#9722
brave/browser-laptop#10561
brave/browser-laptop#9083
brave/browser-laptop#9671
brave/browser-laptop#10038
brave/browser-laptop#10384
brave/browser-laptop#10532
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.18.x Hotfix 1 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use muon's tab_strip_model for driving index and active brave/browser-laptop
9 participants
@bbondy @alexwykoff @kjozwiak @luixxiul @cezaraugusto @bsclifton @cndouglas @Jacalz @LaurenWags