Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Context menu bookmarks #10054

Closed
NejcZdovc opened this issue Jul 19, 2017 · 0 comments · Fixed by #10301
Closed

Context menu bookmarks #10054

NejcZdovc opened this issue Jul 19, 2017 · 0 comments · Fixed by #10301
Assignees
@NejcZdovc
Labels
feature/bookmarks feature/context-menu hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jul 19, 2017 •
edited by luixxiul
Loading

Test plan

#10301 (comment)

Describe the issue you encountered:
We shouldn't generate the whole context menu tree when you click on the folder. We should generate it dynamically.

We would need to modify this function https://github.com/brave/browser-laptop/blob/master/app/renderer/components/common/contextMenu.js?utf8=%E2%9C%93#L183 so that you could pass custom functions for hover event.

This function generate the whole tree https://github.com/brave/browser-laptop/blob/master/app/renderer/reducers/contextMenuReducer.js?utf8=%E2%9C%93#L516
@NejcZdovc NejcZdovc added this to the 0.20.x (Developer Channel) milestone Jul 19, 2017
@NejcZdovc NejcZdovc self-assigned this Jul 19, 2017
@NejcZdovc NejcZdovc added perf hackathon Legacy label for a hackaton. labels Jul 19, 2017
@darkdh darkdh mentioned this issue Jul 27, 2017
Closed
@bsclifton bsclifton mentioned this issue Jul 28, 2017
Closed
35 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Beta Channel), 0.20.x (Developer Channel) Aug 1, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 4, 2017
@NejcZdovc
Improves bookmark folder render for context menu
8b69d79 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 4, 2017
@NejcZdovc
Improves bookmark folder render for context menu
4fb2f73 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 4, 2017
@NejcZdovc
Improves bookmark folder render for context menu
e0fadad 
Resolves brave#10054

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Aug 4, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 4, 2017
@NejcZdovc
Improves bookmark folder render for context menu
3235bf9 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 4, 2017
@NejcZdovc
Improves bookmark folder render for context menu
d60717a 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 5, 2017
@NejcZdovc
Improves bookmark folder render for context menu
4015e2c 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 8, 2017
@NejcZdovc
Improves bookmark folder render for context menu
928e93a 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 9, 2017
@NejcZdovc
Improves bookmark folder render for context menu
c011b85 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 9, 2017
@NejcZdovc
Improves bookmark folder render for context menu
957cdc2 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 9, 2017
@NejcZdovc
Improves bookmark folder render for context menu
85be36d 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 24, 2017
@NejcZdovc
Improves bookmark folder render for context menu
f0719c0 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 5, 2017
@NejcZdovc
Improves bookmark folder render for context menu
078903c 
Resolves brave#10054

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 12, 2017
@NejcZdovc
Improves bookmark folder render for context menu
d45be64 
Resolves brave#10054

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Sep 12, 2017
@bsclifton
Merge pull request #10301 from NejcZdovc/hotfix/#10054-contextMenu
49d4cd9 
Improves bookmark folder render for context menu
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/bookmarks feature/context-menu hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Improves bookmark folder render for context menu NejcZdovc/browser-laptop
5 participants
@bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags