Update aphrodite to 1.2.4

[luixxiul]

Test plan

#10234

1. Make sure the issue reported on regression - Clicking inside Extension Popup Dismisses Popup #10029 does not happen again

---

See https://github.com/Khan/aphrodite/blob/master/CHANGELOG.md for changelog

[bsclifton]

Removing milestone and marking as reverted. This was removed with 38f4618 which was needed to fix #10029.

We should be able to consider upgrading again once #10133 is finished

Please note that per semver, the ^ means any compatible version. Having ^1.0.0 was already grabbing the latest 1.0 release. More info available at https://docs.npmjs.com/files/package.json

[cezaraugusto]

@luixxiul actually that's not a bug with Aphrodite. It's not clear where it was added but Aphrodite checks for production env var and concatenates strings. It should be nothing for us be we still rely on legacy code that depends on className.

For example in main.js we are checking matches against classList like node.matches('[class^="popupWindow"]'). It works in dev but as soon as build is ready, there's no class starting with popupWindow, so we always return false for such checks in production.

The fastest take to unblock next release was to freeze Aphrodite before that addition. But short term is to eliminate all class-dependent code as they're fragile and just re-use Aphrodite at latest.

[bsclifton]

@luixxiul if you upgrade, please be sure not to use the ^ in the version 😄 (ex: prefer "1.2.3" over "^1.2.3")

[luixxiul]

Here's a discussion if another variable should be applied to minify classname: Khan/aphrodite#246 (comment)

[bsclifton]

Removing milestone. We can attempt this once #10551 is completed

[luixxiul]

aphrodite was updated to 1.2.4.

https://github.com/Khan/aphrodite/blob/master/CHANGELOG.md#124