Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update Aphrodite to 1.2.3 #10234

Closed
wants to merge 1 commit into from
Closed

Update Aphrodite to 1.2.3 #10234

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 1, 2017

Closes #10062
Unblock #9851

Auditors:

Test Plan:

  1. Make sure the issue reported on regression - Clicking inside Extension Popup Dismisses Popup #10029 does not happen again

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

CC @jonathansampson @cezaraugusto

Closes #10062
Unblock #9851

Auditors:

Test Plan:
1. Make sure the issue reported on #10029 does not happen again
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 1, 2017
@luixxiul luixxiul requested a review from bsclifton August 1, 2017 17:34
@luixxiul luixxiul requested review from cezaraugusto and removed request for cezaraugusto and bsclifton August 1, 2017 18:11
@luixxiul luixxiul modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Aug 1, 2017
@luixxiul luixxiul self-assigned this Aug 2, 2017
@cezaraugusto
Copy link
Contributor

looks good but we still rely on some code for classLIst so I'll mark this as blocked until they're done, doing that now.

@bsclifton
Copy link
Member

Closing as this is old and there may be other work needed before we can accept

@bsclifton bsclifton closed this Aug 22, 2017
@cezaraugusto
Copy link
Contributor

fyi blocking issue is #10551

@bsclifton bsclifton removed this from the 0.21.x (Nightly Channel) milestone Aug 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants