This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Brave should not exit when every tab is pinned #10117
Labels
addressed-with-brave-core
Needs confirmation, but this issue may be resolved with Brave Core.
feature/pinned-tabs
priority/P4
Minor loss of function. Workaround usually present.
QA/test-plan-specified
release-notes/include
suggestion
usability
Comments
|
I remember that @bradleyrichter agreed with this. |
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 16, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 16, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
8 tasks
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 26, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 27, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 27, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 28, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
bsclifton
pushed a commit
to petemill/browser-laptop
that referenced
this issue
Aug 29, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
|
I tried this out on master- appears to have been fixed by #10531 😄 |
|
Reproduced on MacOS. STR:
|
|
Also Pinned tabs should not close at all (whether it's the only tab or not) |
|
Windows 8 does not have the ability to have a no-window app open state. This is why closing the last window closes Brave. If we want to eliminate this issue, we need to create a blocking feature. One solution is to create a New Tab after the user closes the last non-pinned tab in a given window. If the new tab is the last, then disable the close button. @bsclifton What do you think of this solution? Safari on Mac does something similar. |
alexwykoff
added
the
priority/P4
bsclifton
added
the
addressed-with-brave-core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
Kinda
Describe the issue you encountered:
Brave closes completely when you press Ctrl+W and there is no normal tab.
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 8.1
Brave Version (revision SHA):
dev channel / 4e46480
Steps to reproduce:
Actual result:
Brave completely exits / closes
Expected result:
Ctrl + W should NOT close Brave, should not even close Pinned tab.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
This is a really fresh install, installed today.
Is this an issue in the currently released version?
I don't know, new install after a long time
Can this issue be consistently reproduced?
Yes
The text was updated successfully, but these errors were encountered: