Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove keytar dependency #10226

Closed
luixxiul opened this issue Aug 1, 2017 · 1 comment
Closed

Remove keytar dependency #10226

luixxiul opened this issue Aug 1, 2017 · 1 comment
Assignees
@diracdeltas @darkdh
Labels
dev-setup feature/password-manager OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 1, 2017 •
edited
Loading

Test plan

Make sure the install instruction on a fresh environment works:
https://github.com/brave/browser-laptop#on-debian--ubuntu-mint
https://github.com/brave/browser-laptop#on-fedora

Describe the issue you encountered:

Remove keytar dependency. See: #10227 (comment)

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 1, 2017
@luixxiul luixxiul mentioned this issue Aug 1, 2017
Closed
8 tasks
@luixxiul luixxiul modified the milestones: 0.22.x, 0.21.x (Nightly Channel) Aug 1, 2017
@luixxiul luixxiul changed the title Update keytar to 4.0.4 Remove keytar dependency Aug 2, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 2, 2017

Renamed the title based on the discussion here: #10227 (comment)

@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.22.x Aug 2, 2017
diracdeltas added a commit that referenced this issue Aug 15, 2017
@diracdeltas
Remove keytar and gnome-keyring deps
e93394f 
Give up on migrating old passwords for users who are updating from <0.15.300 to 0.21 and above.

Fix #10226

Test Plan:
npm run test -- --grep='passwords'
@diracdeltas diracdeltas mentioned this issue Aug 15, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Aug 16, 2017
@diracdeltas
Remove keytar and gnome-keyring deps
01ad4d2 
Give up on migrating old passwords for users who are updating from <0.15.300 to 0.21 and above.

Fix #10226

Test Plan:
npm run test -- --grep='passwords'
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
Closed
Closed
This was referenced Jan 22, 2018
Closed
Closed
This was referenced Jan 24, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@darkdh darkdh

Labels
dev-setup feature/password-manager OS/unix-like/linux QA/checked-Linux QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@diracdeltas @bbondy @luixxiul @darkdh @LaurenWags