Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

browser freeze when syncing to profile with 6000+ bookmarks #10273

Closed
diracdeltas opened this issue Aug 3, 2017 · 0 comments
Closed

browser freeze when syncing to profile with 6000+ bookmarks #10273

diracdeltas opened this issue Aug 3, 2017 · 0 comments
Assignees
@diracdeltas
Labels
hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Aug 3, 2017 •
edited by luixxiul
Loading

Test plan

#10281 (comment)

  1. sync to the 'conj...' profile (sent by DM)
  2. observe that the receiving browser freezes indefinitely

may be because getSiteDataFromRecord takes about 300ms per record
@diracdeltas diracdeltas added hackathon Legacy label for a hackaton. perf regression labels Aug 3, 2017
@diracdeltas diracdeltas self-assigned this Aug 3, 2017
@diracdeltas diracdeltas mentioned this issue Aug 3, 2017
Merged
8 tasks
@diracdeltas diracdeltas modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Aug 3, 2017
diracdeltas added a commit that referenced this issue Aug 4, 2017
@diracdeltas
minimize Immutable conversions to improve sync perf
23db757 
fix #10273
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@diracdeltas @dfperry5
minimize Immutable conversions to improve sync perf
fcf8882 
fix brave#10273
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 9, 2018
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
This was referenced Jan 24, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
hackathon Legacy label for a hackaton. perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@diracdeltas @bbondy @kjozwiak @luixxiul @srirambv @LaurenWags