-
Notifications
You must be signed in to change notification settings - Fork 973
Brave freezes when opening tabs while a window is loading #10866
Comments
Duplicate of #10749. |
Sounds good! Please remove the duplicate tag. |
Partially solves #10866 A second issue remains for #10866 where there's a race condition on the tab index that is used. This can exist without that though. Browser process now registers the process right away and callbacks are registered from the window store. It also waits until the window is ready before dispatching now.
This issue has become too common of an occurrence and it seems its happening more regularly than before with fewer tabs than usual as well. The unresponsiveness was always an issue but the crashes weren't as regular as they have been recently, meaning before it either crashed because of a lot tabs were available and recently with fewer tabs or because the browser hadn't been refreshed in long while. Strange thing is I can still access the contents within the page, essentially make the last viewed website function almost properly with the exception of the url bar as you can see from the gif. It seems as though I've just been locked out of the browser despite it probably working fine behind the scene. |
@NumDeP good catch- this bug is crashing the UI and you can get the specific error message by pressing Shift + F8 to open the Browser developer tools and viewing the console tab (which should help us find the issue!) If it happens again, a screenshot is appreciated 😄 |
Hi @bsclifton any particular part of the console you'd like me to highlight because its literally just occurred now. All I can see is the information in this screenshot. |
Partially solves #10866 A second issue remains for #10866 where there's a race condition on the tab index that is used. This can exist without that though. Browser process now registers the process right away and callbacks are registered from the window store. It also waits until the window is ready before dispatching now.
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
Fix #10866 Changes in this PR: - Browser process now registers the process right away for the dispatcher.. - Callbacks are registered from the window store. - Waits until the window is ready before dispatching, queues up messages sent before this. - No extensions.createTab will be issued before a window is ready.
@NumDeP thanks for capturing that- seems that no error is being logged |
Did you search for similar issues before submitting this one?
Yes.
Describe the issue you encountered:
Brave freezes if you try to open tabs when a window has not loaded.
Platform (Win7, 8, 10? macOS? Linux distro?):
macOS 10.12.x.
Brave Version (revision SHA):
0.18.29 (85f059d)
Steps to reproduce:
Or macOS-only:
Actual result:
Brave freezes.
Expected result:
The tabs should be opened.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Not sure.
Is this an issue in the currently released version?
Yes, 0.18.29.
Can this issue be consistently reproduced?
Almost all the time.
Extra QA steps:
1.
2.
3.
Screenshot if needed:
None.
Any related issues:
Might be related to one of the freezing issues.
The text was updated successfully, but these errors were encountered: