Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

History limit in the state #10895

Closed
NejcZdovc opened this issue Sep 11, 2017 · 13 comments
Closed

History limit in the state #10895

NejcZdovc opened this issue Sep 11, 2017 · 13 comments
Assignees
@NejcZdovc
Labels
bug feature/history initiative/perf QA/no-qa-needed release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

Describe the issue you encountered:

With site split PR I accidentally removed history limit in the state, so right now we are saving all history sites in the state without any limitations.
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 11, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 11, 2017
@NejcZdovc NejcZdovc changed the title History limit History limit in the sate Sep 11, 2017
@luixxiul luixxiul changed the title History limit in the sate History limit in the state Sep 11, 2017
@luixxiul
Copy link
Contributor

On packaged build based on the latest master I notice the URL bar performance gets worse clearly. Is it because of this bug?

@luixxiul luixxiul added the bug label Sep 11, 2017
@NejcZdovc
Copy link
Contributor Author

@luixxiul I don't think that we already have packaged build based on the latest master

@luixxiul
Copy link
Contributor

CHANNEL=dev npm run build-package

@NejcZdovc
Copy link
Contributor Author

channel dev is 0.20.x, nightly is 0.21.x == the latest master

@luixxiul
Copy link
Contributor

luixxiul commented Sep 11, 2017 •
edited
Loading

I think CHANNEL=dev is not renamed to the latest status, because when you run git fetch upstream master && git rebase upstream/master && CHANNEL=dev npm run build-package you get

Brave: 0.20.0
V8: 6.1.534.31
rev: 1eca241
Muon: 4.4.15
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 61.0.3163.71

I am pretty sure it is based on the latest master as #10238 is applied to the build.

@bsclifton
Copy link
Member

bsclifton commented Sep 11, 2017 •
edited
Loading

@luixxiul @NejcZdovc when we created the 0.20.x branch, we likely didn't increment the version of master to 0.21.0 in package.json. I went ahead and did that right now with 59d1627

@bsclifton
Copy link
Member

@luixxiul also: dev is now displayed as Release thanks to @prasanthp96 via #10387 😄

@NejcZdovc
Copy link
Contributor Author

ok back to the original comment from @luixxiul. Is this performance problem only with packaged build or is the problem on regular development run as well?

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 12, 2017
@NejcZdovc
Adds history limit into the historySites
02b9862 
Resolves brave#10895

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 12, 2017
Merged
8 tasks
@luixxiul
Copy link
Contributor

I haven't tried the same profile on npm run watch so I am not sure.

@NejcZdovc
Copy link
Contributor Author

@luixxiul can you please try this scenario so that we know if the problem is limited to package. Thank you

@luixxiul
Copy link
Contributor

reproduced on npm run watch as well

@NejcZdovc
Copy link
Contributor Author

ok, can you please define STR, so that I can test it as well

@luixxiul
Copy link
Contributor

it is reproduced on my browser's profile so I cannot.

@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Dec 22, 2017
@NejcZdovc @bsclifton
Adds history limit into the historySites
a756b0f 
Resolves brave#10895

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 4, 2018
@NejcZdovc
Adds history limit into the historySites
db69ba6 
Resolves brave#10895

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Jan 8, 2018
@bsclifton
Merge pull request #10911 from NejcZdovc/hotfix/#10895-history
a24496c 
Adds history limit into the historySites
bsclifton added a commit that referenced this issue Jan 8, 2018
@bsclifton
Merge pull request #10911 from NejcZdovc/hotfix/#10895-history
b36d1eb 
Adds history limit into the historySites
bsclifton added a commit that referenced this issue Jan 8, 2018
@bsclifton
Merge pull request #10911 from NejcZdovc/hotfix/#10895-history
f49ba73 
Adds history limit into the historySites
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/history initiative/perf QA/no-qa-needed release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @bsclifton @NejcZdovc @srirambv