Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

visiting about:preferences#search should not set cookies #11108

Closed
diracdeltas opened this issue Sep 23, 2017 · 1 comment · Fixed by #12698
Closed

visiting about:preferences#search should not set cookies #11108

diracdeltas opened this issue Sep 23, 2017 · 1 comment · Fixed by #12698
Assignees
@diracdeltas
Labels
misc/favicon priority/P4 Minor loss of function. Workaround usually present. privacy QA/test-plan-specified release-notes/include sec-low security
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Sep 23, 2017 •
edited by luixxiul
Loading

Test plan

#12698 (comment)

i noticed that opening about:preferences#search causes cookies to be set for various sites, probably because Brave is making requests to load their favicons:
screen shot 2017-09-23 at 6 53 48 am

we should not load the favicons remotely
@luixxiul
Copy link
Contributor

related: #2697 - Cache favicons (to prevent fetching each time Brave is reloaded)

@diracdeltas diracdeltas added priority/P4 Minor loss of function. Workaround usually present. sec-low labels Oct 3, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@diracdeltas diracdeltas self-assigned this Dec 20, 2017
@diracdeltas diracdeltas mentioned this issue Jan 17, 2018
Closed
diracdeltas added a commit that referenced this issue Jan 17, 2018
@diracdeltas
Load search favicons locally in about:preferences
ac59329 
fix #12689
fix #11108

Test Plan:
1. go to about:preferences and open the 'network requests' tab in devtools
2. click on the search preferences tab. you should not see any network requests to remote sites.
3. all the search favicons should load correctly
@diracdeltas diracdeltas mentioned this issue Jan 17, 2018
Merged
10 tasks
@luixxiul luixxiul modified the milestones: Backlog (Prioritized), 0.20.x (Release Channel) Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
misc/favicon priority/P4 Minor loss of function. Workaround usually present. privacy QA/test-plan-specified release-notes/include sec-low security
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Load search favicons locally in about:preferences brave/browser-laptop
4 participants
@diracdeltas @luixxiul @cezaraugusto @bsclifton