Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Copied text overlaps on the info message #11289

Closed
srirambv opened this issue Oct 5, 2017 · 5 comments
Closed

Copied text overlaps on the info message #11289

srirambv opened this issue Oct 5, 2017 · 5 comments
Assignees
@cezaraugusto
Labels
bug feature/about-pages feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 5, 2017 •
edited by luixxiul
Loading

Test plan

  1. Enable payments
  2. Click Add funds
  3. Click any currencies button
  4. Click the clipboard icon to copy the wallet address,
  5. Test that the tool tip appears on the top of the clipboard icon

Description

Copied text overlaps on the info message

Steps to Reproduce

  1. Build on the bat-integration branch
  2. Enable payments
  3. Click Add funds
  4. Click any currencies button
  5. Click the clipboard icon to copy the wallet address,

Actual result:

copied text overlaps on the info text

copyExpected result:

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

Brave 0.21.0
V8 6.1.534.41
rev 2ca8815
Muon 4.4.25

Reproducible on current live release:

Additional Information
@srirambv srirambv added bug copy/content/text priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Oct 5, 2017
@srirambv srirambv added this to the 0.19.x (Beta Channel) milestone Oct 5, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Oct 5, 2017

On which rev?

@srirambv
Copy link
Collaborator Author

srirambv commented Oct 5, 2017

Sorry thought had pasted the info. Updated issue

@luixxiul luixxiul mentioned this issue Oct 5, 2017
Closed
8 tasks
@cezaraugusto
Copy link
Contributor

cezaraugusto commented Oct 5, 2017 •
edited by NejcZdovc
Loading

fixed in bat-integration #11231 branch thanks for reporting!

@cezaraugusto cezaraugusto reopened this Oct 5, 2017
@NejcZdovc NejcZdovc mentioned this issue Oct 5, 2017
Merged
8 tasks
NejcZdovc added a commit that referenced this issue Oct 6, 2017
@NejcZdovc
Adds BAT support
5813411 
Resolves #9740
Resolves #10945
Resolves #11251 
Resolves #11264
Resolves #11285
Resolves #11289
Resolves #11292
Resolves #11293
@luixxiul
Copy link
Contributor

luixxiul commented Oct 7, 2017

how the tooltip should actually appear?

@luixxiul luixxiul added QA/test-plan-required release-notes/exclude feature/about-pages and removed copy/content/text priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Oct 7, 2017
@cezaraugusto
Copy link
Contributor

at the top

This was referenced Oct 9, 2017
Closed
Closed
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Adds BAT support
f9990fd 
Resolves brave#9740
Resolves brave#10945
Resolves brave#11251 
Resolves brave#11264
Resolves brave#11285
Resolves brave#11289
Resolves brave#11292
Resolves brave#11293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/about-pages feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@luixxiul @cezaraugusto @NejcZdovc @srirambv @LaurenWags