reduce size of session-store-1 by removing 'data:' URLs #11582
Comments
|
see 11a2bc4#diff-70ca3257d79251708167c6ce9bf1cd81 |
|
i think most/all of the data URLs are from external sites which use data: URLs as their favicon URL |
|
@NumDeP she ( @diracdeltas) wasn't involved with that issue, I was. There are thousands of issues in our backlog, so even though I was involved I had to re-read the details I don't see any reference to data URL/URIs in that issue, so I wasn't ignoring you Let's keep things civil here- we want to help 😄 |
|
Sorry. It's just that from all the crashes I've been hoarding all the S-S-1's locally and going through the process of going through unnecessary data. |
|
@NumDeP I understand your frustration- there are a lot of small details that we're constantly evaluating and trying to assess the priority for (if you use GitHub's If you have a suggestion for what we can remove, that is appreciated. Please do know that harassment of any kind (including comments or language which make a contributor uncomfortable) is not welcomed We keep a fairly up to date record of what goes into the session store here: If you find data that you think can be removed, please open an issue. If you're not comfortable with making a PR, we should be able to help make the change (or we could also give it some visibility by tagging it as |
|
i have a fix for this, it seems to help for performance but would be good to test against a benchmark |
This moves data:* URLs in the ledger appState to external image files, which reduces the size of my session-store-1 from ~25 MB to 5 MB. Fix #11582 Test plan: 1. Copy session-store-1 from a Brave profile that has had payments enabled for a while to your brave-development appData directory. 2. Start the browser and go to about:preferences#payments. The synopsis table should appear fine. 3. Close the browser. 4. In your brave-development appData directory, you should now see a ledger-favicons subdirectory which contains a lot of image files. You should also notice that session-store-1 is now much smaller. 5. Repeat step 2.
|
added ledger label because all the data favicons i had were from the ledger |
bbondy
modified the milestones:
0.19.x Hotfix 5 (Release channel),
0.19.x Hotfix 6 (Release channel)
bsclifton
modified the milestones:
0.19.x Hotfix 6 (Release channel),
0.20.x (Beta Channel)
|
Moving to 0.20.x (as the next 0.19.x release is reserved for Chromium 63) |
alexwykoff
added
the
priority/P4
This moves data:* URLs in the ledger appState to external image files, which reduces the size of my session-store-1 from ~25 MB to 5 MB. Fix #11582 Test plan: 1. Copy session-store-1 from a Brave profile that has had payments enabled for a while to your brave-development appData directory. 2. Start the browser and go to about:preferences#payments. The synopsis table should appear fine. 3. Close the browser. 4. In your brave-development appData directory, you should now see a ledger-favicons subdirectory which contains a lot of image files. You should also notice that session-store-1 is now much smaller. 5. Repeat step 2.
This moves data:* URLs in the ledger appState to external image files, which reduces the size of my session-store-1 from ~25 MB to 5 MB. Fix #11582 Test plan: 1. Copy session-store-1 from a Brave profile that has had payments enabled for a while to your brave-development appData directory. 2. Start the browser and go to about:preferences#payments. The synopsis table should appear fine. 3. Close the browser. 4. In your brave-development appData directory, you should now see a ledger-favicons subdirectory which contains a lot of image files. You should also notice that session-store-1 is now much smaller. 5. Repeat step 2.
Test plan
#11754 (comment)
My production session-store-1 file is now 23MB.
egrep -o '"data:(.+?)"'shows that nearly 80% of this (18MB) of this isdata:URLs, mostly favicons it seems. We should investigate if the favicons can be moved to external files or replaced with links to the favicon URL.The text was updated successfully, but these errors were encountered: