Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

White flash after tab open or close #11813

Closed
petemill opened this issue Nov 6, 2017 · 0 comments · Fixed by #11818
Closed

White flash after tab open or close #11813

petemill opened this issue Nov 6, 2017 · 0 comments · Fixed by #11818

Comments

@petemill
Copy link
Member

petemill commented Nov 6, 2017

Test plan

See #11818

Description

When opening a tab, there is a flash of the background of the <webview> component, which is explicitly set to white in window.less.
When closing a tab, there is a flash of the background of the whole window (or at least div.tabContainer) as the active frame is removed, but the next active frame is not set active yet.

The opening tab scenario can be solved by setting the <webview> background to not be white in certain cases, or not showing it until the background of the incoming page is ready (perhaps, more risky).

the closing tab scenario can be solved by either:

  1. Setting next active tab before closing the tab, and then waiting Xms to actually close the tab (tested it and works OK, but the browser process feels the wrong place to do it for a rendering issue), or;
  2. Keeping the frame (and <webview>) around until the newly active frame has a chance to be shown (tested and works OK, but an arbitrary number of ms)

Steps to Reproduce

Set new tab page to Dashboard.
Open and close many tabs.

Actual result:
Observe white flashes

Expected result:
No white flashes between opening or closing tabs

Reproduces how often:
100%

Brave Version

about:brave info:
master

Reproducible on current live release:
Yes

Additional Information

PR incoming

@petemill petemill added this to the Triage Backlog milestone Nov 6, 2017
@petemill petemill self-assigned this Nov 6, 2017
petemill added a commit that referenced this issue Nov 6, 2017
…s in the image when loaded

Fix #5309

Note: the flashes of white that are still present on both tab open and close are from both the <webview> background on open, and the window background on close (when no other tab is shown). These will be addressed in #11813
petemill added a commit that referenced this issue Nov 7, 2017
…s in the image when loaded

Fix #5309

Note: the flashes of white that are still present on both tab open and close are from both the <webview> background on open, and the window background on close (when no other tab is shown). These will be addressed in #11813
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.