-
Notifications
You must be signed in to change notification settings - Fork 973
Promotion error should only be shown in verbose mode #12311
Comments
@SohumB this is expected, because there are currently no promotions active. Will remove logging for this use case. Thank you for your report |
Oh, my apologies. The actual issue then is that no wallet addresses for funding payments shows up. I'll make a new issue. [Edit] ...or they're showing up now. Transient error, I guess! My apologies, carry on as you were :) |
@SohumB yes please do if you have any more problems with payments |
Resolves brave#12311 Auditors: Test Plan:
Show error only when in verbose mode
Show error only when in verbose mode
Show error only when in verbose mode
Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher. |
In addition to Test Plan, started Brave with LEDGER_VERBOSE=true to see 404 promotion error. |
Received the 404 when running brave via
Ensure that I didn't get the above 404 error when running brave without |
Test plan
See #12312
Description
#12080 again. Error retrieving promotion Error: HTTP response 404 for GET /v1/grants?paymentId=[id]
Steps to Reproduce
Reproduces how often:
100%
Brave Version
about:brave info:
Brave: 0.19.116
rev: 139c117
Muon: 4.5.16
libchromiumcontent: 62.0.3202.94
V8: 6.2.414.42
Node.js: 7.9.0
Update Channel: Release
OS Platform: Linux
OS Release: 4.13.0-1-amd64
OS Architecture: x64
The text was updated successfully, but these errors were encountered: