Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Promotion error should only be shown in verbose mode #12311

Closed
SohumB opened this issue Dec 18, 2017 · 6 comments
Closed

Promotion error should only be shown in verbose mode #12311

SohumB opened this issue Dec 18, 2017 · 6 comments

Comments

@SohumB
Copy link

SohumB commented Dec 18, 2017

Test plan

See #12312

Description

#12080 again. Error retrieving promotion Error: HTTP response 404 for GET /v1/grants?paymentId=[id]

Steps to Reproduce

  1. Clean install 0.19.116
  2. Launch from console
  3. Enable payments, no claim tokens notification shown
  4. Console shows error 404

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.19.116
rev: 139c117
Muon: 4.5.16
libchromiumcontent: 62.0.3202.94
V8: 6.2.414.42
Node.js: 7.9.0
Update Channel: Release
OS Platform: Linux
OS Release: 4.13.0-1-amd64
OS Architecture: x64

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Dec 18, 2017

@SohumB this is expected, because there are currently no promotions active. Will remove logging for this use case. Thank you for your report

@SohumB
Copy link
Author

SohumB commented Dec 18, 2017

Oh, my apologies. The actual issue then is that no wallet addresses for funding payments shows up. I'll make a new issue.

[Edit] ...or they're showing up now. Transient error, I guess! My apologies, carry on as you were :)

@NejcZdovc
Copy link
Contributor

@SohumB yes please do if you have any more problems with payments

@NejcZdovc NejcZdovc added this to the 0.19.x Hotfix 9 milestone Dec 18, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 18, 2017
Resolves brave#12311

Auditors:

Test Plan:
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 9, 0.21.x (Developer Channel) Dec 20, 2017
bsclifton added a commit that referenced this issue Dec 22, 2017
Show error only when in verbose mode
@bsclifton bsclifton changed the title Error retrieving promotion Promotion error should only be shown in verbose mode Dec 22, 2017
bsclifton added a commit that referenced this issue Dec 22, 2017
Show error only when in verbose mode
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
Show error only when in verbose mode
@LaurenWags
Copy link
Member

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

@LaurenWags
Copy link
Member

In addition to Test Plan, started Brave with LEDGER_VERBOSE=true to see 404 promotion error.

@srirambv srirambv added 0.21.x issue first seen in 0.21.x QA/checked-Win64 labels Feb 27, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Feb 27, 2018

Received the 404 when running brave via LEDGER_VERBOSE=true brave-beta --user-data-dir-name=brave-beta:

{"statusCode":404,"error":"Not Found","message":"no promotions available"}
Error retrieving promotion Error: HTTP response 404 for GET /v1/grants

Ensure that I didn't get the above 404 error when running brave without LEDGER_VERBOSE=true.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.