Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinned tabs duplicated after update to 0.20.16 #12580

Closed
LaurenWags opened this issue Jan 9, 2018 · 1 comment
Closed

pinned tabs duplicated after update to 0.20.16 #12580

LaurenWags opened this issue Jan 9, 2018 · 1 comment
Assignees
@petemill
Labels
0.20.x issue first seen in 0.20.x bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

Description

Pinned tabs are duplicated after update to 0.20.16

Steps to Reproduce

  1. Create a profile on 0.19.131 with a few pinned tabs (I had 3) and multiple windows (I had 3).
  2. Manually update your profile to 0.20.16
  3. Open 0.20.16.
  4. Your pinned tabs in at least one window are duplicated.
  5. Close/Reopen Brave.
  6. Now pinned tabs in all windows are duplicated.

Actual result:
Pinned tabs are duplicated.

Expected result:
Pinned tabs should not be duplicated.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.16
V8 | 6.3.292.49
rev | 0c42d0b
Muon | 4.5.36

Reproducible on current live release:
no

Additional Information

I have a profile I can share (testing profile) if that will help.
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 9, 2018
@petemill petemill self-assigned this Jan 9, 2018
petemill added a commit that referenced this issue Jan 10, 2018
@petemill
Correctly converts key from pre-split sites to post-split pinned sites
1d63ee0 
Fix #12580
Prevents duplicated pinned sites
Migration was attempting to insert pinned site with key format [location]|[partition]|0 when expected format is [location]|[partition]
Also ensures pinned site order stays consistent across migrations, windows, and app starts
petemill added a commit that referenced this issue Jan 10, 2018
@petemill
Correctly converts key from pre-split sites to post-split pinned sites
3c11c38 
Fix #12580
Prevents duplicated pinned sites
Migration was attempting to insert pinned site with key format [location]|[partition]|0 when expected format is [location]|[partition]
Also ensures pinned site order stays consistent across migrations, windows, and app starts
@petemill petemill mentioned this issue Jan 10, 2018
Merged
10 tasks
@petemill
Copy link
Member

Jazzy gif from @LaurenWags illustrating the issue:
duplicatepinnedtabs

petemill added a commit that referenced this issue Jan 10, 2018
@petemill
Correctly converts key from pre-split sites to post-split pinned sites
cca8a0c 
Fix #12580
Prevents duplicated pinned sites
Migration was attempting to insert pinned site with key format [location]|[partition]|0 when expected format is [location]|[partition]
Also ensures pinned site order stays consistent across migrations, windows, and app starts, and is compatible with pinning new sites, where order is set to the count of existing pinned sites
This was referenced Jan 22, 2018
Closed
Closed
Closed
This was referenced Jan 24, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.20.x issue first seen in 0.20.x bug feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @kjozwiak @luixxiul @bsclifton @srirambv @LaurenWags