Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dynamically build monthly amount dropdown #12727

Closed
NejcZdovc opened this issue Jan 19, 2018 · 5 comments · Fixed by #12728
Closed

Dynamically build monthly amount dropdown #12727

NejcZdovc opened this issue Jan 19, 2018 · 5 comments · Fixed by #12728

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 19, 2018

Test plan

See #12728

Description

We need to get data from server about monthly amount drop down. If user has different amount selected than we provide in the server list we need to keep it.

@NejcZdovc NejcZdovc self-assigned this Jan 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.19.x Hotfix 13, 0.20.x (Beta Channel) Jan 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 19, 2018
bsclifton added a commit that referenced this issue Jan 19, 2018
Adds dynamic dropdown for monthly amounts
bsclifton added a commit that referenced this issue Jan 19, 2018
Adds dynamic dropdown for monthly amounts
bsclifton added a commit that referenced this issue Jan 19, 2018
Adds dynamic dropdown for monthly amounts
@bsclifton
Copy link
Member

@NejcZdovc when you have time, can you create a test plan for this? Thanks 😄 👍

@NejcZdovc
Copy link
Contributor Author

@bsclifton test plan can be found here #12728 (comment)

@kjozwiak
Copy link
Member

@NejcZdovc I've also noticed the following possible issues. I'm assuming these are expected I wanted to double check with you first. Possible issues:

You can only set payments.contribution-amount to either a whole number (10 BAT) or a half number (10.5 BAT). Using other denominations such as 10.7 BAT and 10.3 BAT doesn't work.

The second thing that I noticed is that once you change the value to something else from the dropdown menu, the "dynamic" value is removed from the dropdown list. Should those values be saved in the dropdown list? I'm assuming this is expected so we don't end up polluting the dropdown with a bunch of different values.

@LaurenWags
Copy link
Member

@NejcZdovc - noticing that if I change my Monthly Budget to 15 BAT and close/reopen Brave, it changes to 75 BAT. Similarly, if I choose 20 BAT and close/reopen, it changes to 100 BAT.

@LaurenWags LaurenWags reopened this Jan 23, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2018
Resolves brave#12727

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Jan 23, 2018
bsclifton added a commit that referenced this issue Jan 23, 2018
bsclifton added a commit that referenced this issue Jan 23, 2018
@srirambv
Copy link
Collaborator

Modified value is retained after restart on 0.20.20. Tried the following scenarios

  1. Changed payments.contribution-amount value to 0.99 -> Restart -> Showed 1.0 BAT
  2. Changed payments.contribution-amount value to 4 -> Restart -> Retained 4 BAT
  3. Changed payments.contribution-amount value to 0.8 -> Restart -> Retained 0.8 BAT
  4. Changed payments.contribution-amount value to 17.35 -> Restart -> Showed 17.4 BAT

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.