-
Notifications
You must be signed in to change notification settings - Fork 973
Dynamically build monthly amount dropdown #12727
Comments
Resolves brave#12727 Auditors: Test Plan:
Resolves brave#12727 Auditors: Test Plan:
Resolves brave#12727 Auditors: Test Plan:
Resolves brave#12727 Auditors: Test Plan:
Resolves brave#12727 Auditors: Test Plan:
Adds dynamic dropdown for monthly amounts
Adds dynamic dropdown for monthly amounts
Adds dynamic dropdown for monthly amounts
@NejcZdovc when you have time, can you create a test plan for this? Thanks 😄 👍 |
@bsclifton test plan can be found here #12728 (comment) |
@NejcZdovc I've also noticed the following possible issues. I'm assuming these are expected I wanted to double check with you first. Possible issues: You can only set The second thing that I noticed is that once you change the value to something else from the dropdown menu, the "dynamic" value is removed from the dropdown list. Should those values be saved in the dropdown list? I'm assuming this is expected so we don't end up polluting the dropdown with a bunch of different values. |
@NejcZdovc - noticing that if I change my Monthly Budget to 15 BAT and close/reopen Brave, it changes to 75 BAT. Similarly, if I choose 20 BAT and close/reopen, it changes to 100 BAT. |
Resolves brave#12727 Auditors: Test Plan:
Modified value is retained after restart on 0.20.20. Tried the following scenarios
|
Test plan
See #12728
Description
We need to get data from server about monthly amount drop down. If user has different amount selected than we provide in the server list we need to keep it.
The text was updated successfully, but these errors were encountered: