browserWindow has no icon

[Kilian]

browserWindow needs an icon for brave to show an icon on Ubuntu or you get a grey icon:

This should be added here:

browser-laptop/js/stores/appStore.js

Line 111 in 75c788a

let mainWindow = new BrowserWindow(Object.assign({

and it should be a png.

[luixxiul]

Confirmed, @bbondy Is branding for Linux ongoing?

• Ubuntu
• Mint (reported at No icon for Brave in Cinnamon panel (Linux Mint) #1209, Brave Web Browser .Desktop File #1235)
• Debian

[bbondy]

would love a PR to fix this @luixxiul

[luixxiul]

On Ubuntu it has been already implemented with a deb package.

closing?

[bbondy]

I'm using Ubuntu 14.04 and it still comes up as unidentified for me.

[luixxiul]

Are you running brave with the deb package right? From console it comes up like that

[bbondy]

yep comes up without the icon for that. Maybe something is messed on my machine or maybe there's a bug.

[Kilian]

if you are not running from a .desktop file that supplies the icon, electron defaults back to the icon specified for the BrowserWindow. This is why in my original report I gave the line number of your BrowserWindow code. Simply add an icon property to it and link a png file, and that will fix this problem directly in your code instead of in a platform specific desktop file.

See also https://kilianvalkhof.com/talks/cross-platform-electron/#/11 :)

[luixxiul]

@Kilian, so is it OK with this?

https://github.com/brave/browser-laptop/blob/master/js/stores/appStore.js#L115

  let mainWindow = new BrowserWindow(Object.assign({
    icon: '/res/app.png',
    // smaller min size for "modal" windows

https://github.com/brave/browser-laptop/blob/master/res/app.png

[Kilian]

I'm not sure if an absolute path also works (as opposed to including __dirname) but other than that, yeah that's how to get an icon on ubuntu :)

[luixxiul]

OK I'm pushing a PR for that. Please ignore the commit above which I mistakenly sent

[luixxiul]

Stopped working. Restarting doesn't help.

[luixxiul]

On non packaged build it usually works, but sometimes not. I'm not sure why.

[bbondy]

I think there's a cache @luixxiul so I think a reboot or a restart of the window manager needs to happen between testing.

I'm going to remove this from 0.10.4 but if there's a fix we can add it back in.