This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill: can't select popup item using arrow keys #1302

Closed

garvankeeley opened this issue Apr 9, 2016 · 8 comments

Assignees

Labels

bug feature/autofill feature/keyboard-shortcuts parity QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include

Milestone

Contributor

garvankeeley commented Apr 9, 2016

STR: begin typing a login that will be autofilled, immediately a popup will appear below the login form field with the suggested autofill. One can click on this suggested autofill, but I can't down-arrow and press enter.

Expected: that down-arrow will select the suggested autofill, and enter key will enter it in the associated form field

diracdeltas self-assigned this

cezaraugusto added the bug label

Sh1d0w mentioned this issue

Unable to select autofill form suggestion by pressing down arrow key #3402

Closed

darkdh mentioned this issue

Autocomplete pulldown with down arrow key #2724

Closed

Sh1d0w mentioned this issue

Form suggestions dropdown not keyboard accessible #3658

Closed

Member

bsclifton commented Sep 5, 2016

Nice screencap by @jkup

bsclifton added the feature/autofill label

This was referenced Sep 5, 2016

Can't down arrow into dropdown for remembered username #3744

Closed

Brave does not react on arrow keys while showing username suggestions on logins #3811

Closed

darkdh mentioned this issue

Feature Request : Autofill selection should be able to be made via cursor keys #3969

Closed

luixxiul mentioned this issue

autofill popup doesn't receive down-arrow on keyboard #4343

Closed

darkdh self-assigned this

darkdh added this to the 1.0.0 milestone

bradleyrichter modified the milestones: 0.12.9dev, 1.0.0

bsclifton modified the milestones: 0.12.10 release , 0.12.9dev

Member

bsclifton commented Nov 8, 2016

Kicking over to 0.12.10

diracdeltas removed their assignment

bbondy modified the milestones: 0.12.11, 0.12.10 release

cndouglas added feature/keyboard-shortcuts parity labels

cndouglas mentioned this issue

Form autocomplete not keyboard accessible #4873

Closed

cndouglas changed the title ~~PW Autofill: can't select popup item using arrow keys~~ Autofill: can't select popup item using arrow keys

cndouglas commented Nov 19, 2016

This applies to both passwords and autofill.

bbondy modified the milestones: 0.13.1, 0.13.0

Member

bbondy commented Nov 22, 2016

@bsclifton would you mind taking this for 0.13.1 (Freeze is on Dec 2nd)? I think you might be able to re-use some experience from the Windows menu navigation with keyboard.

Member

bsclifton commented Nov 23, 2016

@bbondy Sure thing 😄

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

569a5fb

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

2b138a0

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

cc9217a

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

luixxiul added QA/test-plan-specified release-notes/include labels

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

e0f78be

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

cndouglas mentioned this issue

Autofill form option blinks and cannot be clicked #5438

Closed

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

135fad8

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Added arrow navigation to the autofill

39ce5a4

Resolves brave#1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

50b925d

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton pushed a commit that referenced this issue


          Added arrow navigation to the autofill

a7bbdae

Resolves #1302

Auditors: @bsclifton

Test Plan:
- go to website with a form
- submit form so that autofill will be triggered
- go to the same website and double click on the input to trigger autofill
- use down arrow to select value and press enter
- value should be field into the input

bsclifton modified the milestones: 0.13.0, 0.13.1

Member

bbondy commented Jan 26, 2017

we had to revert from 0.13.1 due to #6867 but we'll get it for 0.13.1 as long as #6867 is fixed.

Contributor

NejcZdovc commented Jan 26, 2017

Will fix it, not a problem

This was referenced Feb 3, 2017

Manual Tests for Windows x64 0.13.2 RC2 #7030

Closed

Manual Tests for Windows ia-32 0.13.2 RC3 #7029

Closed

Manual Tests for Linux 0.13.2 RC3 #7028

Closed

Manual Tests for OS X 0.13.2 RC2 #7027

Closed

bbondy added the QA/checked-macOS label

aekeus added the QA/checked-Linux label

luixxiul added the QA/checked-Win32 label

This was referenced Feb 4, 2017

Autofill value selected with keyboard should not be sent with enter key #7052

Closed

Uncaught TypeError: cannot read property 'has' of undefined(...) : onKeyDown @ menubar.js:160 #7055

Closed

srirambv added the QA/checked-Win64 label

srirambv mentioned this issue

Pressing tab on autocomplete suggestion doesn't fill the input field #7132

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.