Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unnatural space next to back button (Windows 10) #1628

Closed
luixxiul opened this issue May 8, 2016 · 10 comments
Closed

Unnatural space next to back button (Windows 10) #1628

luixxiul opened this issue May 8, 2016 · 10 comments
Labels
design A design change, especially one which needs input from the design team. OS/Windows
Milestone

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 8, 2016

On Windows 10 there is unnatural space next to the back button, under "New Tab" (title bar)

Intended?

@bsclifton
Copy link
Member

bsclifton commented May 8, 2016

I also don't like this- it would be easy to fix
(on Mac, it serves a purpose since the close/maximize/minimize buttons are there)
cc: @bradleyrichter

@bbondy
Copy link
Member

bbondy commented May 8, 2016

This is just because of the OS X controls on the left, on Windows the gap shouldn't be there.

I'd imagine adding some css class top level that's called isWindows via check for process.platform === 'win32' would do the trick.

@bradleyrichter
Copy link
Contributor

I'd love to have this fixed.

On May 8, 2016, at 4:52 AM, Brian R. Bondy notifications@github.com wrote:

This is just because of the OS X controls on the left, on Windows the gap shouldn't be there.

I'd imagine adding some css class top level that's called isWindows via check for process.platform === 'win32' would do the trick.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@bsclifton
Copy link
Member

#1638 ready for review 😄

@duff2481
Copy link

@luixxiul using 0.9.5 version on Windows machine and I have the start bar on top of my screen, not the bottom. I constantly need to readjust each time brave is loaded.

@bbondy
Copy link
Member

bbondy commented May 13, 2016

What is the start bar? Do you mean the Windows task bar?

@duff2481
Copy link

yes, task bar.

@luixxiul
Copy link
Contributor Author

Would you please take a screenshot?
2016/05/13 22:36 "duff2481" notifications@github.com:

yes, task bar.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1628 (comment)

@duff2481
Copy link

brave_default_opening

@luixxiul
Copy link
Contributor Author

By the way on Windows 10,

Attention to the top right corner.

Also I opened the new issue #1727 for that issue, thanks.

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. OS/Windows labels Sep 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. OS/Windows
Projects
None yet
Development

No branches or pull requests

5 participants