Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added "Block All" cookie option in bravery panel #1987

Closed
garvankeeley opened this issue May 30, 2016 · 6 comments · Fixed by #7721
Closed

Added "Block All" cookie option in bravery panel #1987

garvankeeley opened this issue May 30, 2016 · 6 comments · Fixed by #7721
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@garvankeeley
Copy link
Contributor

garvankeeley commented May 30, 2016 •
edited by luixxiul
Loading

Test plan

#7721 (comment)
@garvankeeley garvankeeley changed the title Cookie option in bravery panel missing "Block All" Cookie option in bravery panel missing option "Block All" May 30, 2016
@alexwykoff alexwykoff added this to the 0.12.4dev milestone Nov 16, 2016
@alexwykoff
Copy link
Contributor

Shipped

@luixxiul
Copy link
Contributor

I'm just seeing Accept every cookie and Block 3p cookies, not Block every cookie

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Nov 16, 2016
@cndouglas
Copy link

Not shipped yet, as far as I can tell.

@cndouglas cndouglas reopened this Nov 16, 2016
@cndouglas cndouglas removed the needs-info Another team member needs information from the PR/issue opener. label Nov 16, 2016
@cndouglas cndouglas removed this from the 0.12.4dev milestone Nov 16, 2016
@alexwykoff
Copy link
Contributor

My mistake. Read too fast.

@diracdeltas
Copy link
Member

+1 on this, preferably for 1.0. I think this should be done in conjunction with #1268 such that cookies are blocked globally and there is a prompt to whitelist cookies on a page based on origin, because very few users want to block all cookies.

@diracdeltas diracdeltas self-assigned this Feb 13, 2017
@diracdeltas diracdeltas modified the milestones: 1.0.0, 0.13.6 Feb 13, 2017
@diracdeltas
Copy link
Member

For a first-pass I'll only add a setting to allow/deny all on a site

@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
diracdeltas added a commit to brave/sync that referenced this issue Mar 15, 2017
@diracdeltas
add block all cookies to cookieControl enum
0f77c35 
for brave/browser-laptop#1987

auditors: @ayumi
diracdeltas added a commit that referenced this issue Mar 15, 2017
@diracdeltas
Add setting to block all cookies
5e506bb 
fix #1987

Test Plan:
1. automated cookies tests should pass
2. go to https://jsfiddle.net/7ke9r14a/9/ with default cookie settings
3. the page should show blank or "" for all result values
4. in the brave panel, set cookies to "Block all cookies"
5. the page should not load
6. now set cookies to Allow All
7. the page should display non-empty result values
@diracdeltas diracdeltas mentioned this issue Mar 15, 2017
Merged
4 tasks
This was referenced Mar 17, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 17, 2017
Closed
42 tasks
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@alexwykoff alexwykoff changed the title Cookie option in bravery panel missing option "Block All" Added "Block All" cookie option in bravery panel Mar 28, 2017
This was referenced Mar 28, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Add setting to block all cookies brave/browser-laptop
6 participants
@diracdeltas @alexwykoff @luixxiul @garvankeeley @srirambv @cndouglas