Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Qwant to search engine prefs and results #2701

Closed
bradleyrichter opened this issue Jul 24, 2016 · 1 comment
Closed

Add Qwant to search engine prefs and results #2701

bradleyrichter opened this issue Jul 24, 2016 · 1 comment
Assignees
@bsclifton
Labels
feature/search QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 settings
Milestone
0.12.15

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jul 24, 2016 •
edited
Loading

Qwant offers us a bit more than a post URL.

image

code for qwant:
<Url type="application/x-suggestions+json" method="GET" template="https://api.qwant.com/api/suggest/?q={searchTerms}&client=brave »/> <Url type="text/html" method="GET" template="https://www.qwant.com/?q={searchTerms}&client=brave »/>

Something important to notice is the "client=brave" parameter.

CC @bbondy (if further info is needed)
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Jul 24, 2016
@bbondy
Copy link
Member

bbondy commented Jul 25, 2016

mainly just make sure about the parameter pls. Thanks.

@bbondy bbondy mentioned this issue Jul 25, 2016
Closed
@bsclifton bsclifton self-assigned this Aug 24, 2016
@bbondy bbondy assigned jkup and unassigned bsclifton and darkdh Aug 29, 2016
@luixxiul luixxiul mentioned this issue Nov 16, 2016
Closed
@bsclifton bsclifton modified the milestones: 0.13.0, 1.0.0 Nov 29, 2016
@bsclifton bsclifton assigned bsclifton and unassigned jkup Nov 30, 2016
@bsclifton bsclifton mentioned this issue Dec 1, 2016
Merged
4 tasks
bbondy pushed a commit that referenced this issue Dec 13, 2016
@bsclifton @bbondy
Add Qwant.com as a search engine
57b06bb 
Fixes #2701

Auditors: @bbondy

Test Plan:
1. Launch Brave and open Preferences
2. Set Qwant.com as your default search engine and enable suggestions
3. In the omnibox, type "what" and wait for results to show
4. Search in the omnibox, confirm it shows results on qwant.com
5. Try the search engine shortcut, :q and do a search in the omnibox
@bbondy bbondy modified the milestones: 0.12.15, 0.13.0 Dec 13, 2016
This was referenced Dec 13, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/search QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 settings
Projects
None yet
Milestone
0.12.15
Development

No branches or pull requests
8 participants
@jkup @bbondy @alexwykoff @luixxiul @bsclifton @darkdh @bradleyrichter @srirambv